issue: https://linear.app/comm/issue/ENG-2794/make-it-possible-to-display-only-chats-from-a-given-community-in-the
We want to be able to press some button, and see only chats from a given community to be visible in the calendar filters. We want this information to persist when switching between tabs. So we will keep
this as a calendar filter in redux.
This diff introduces the architectural changes required for this - adding and changing types according to what will be needed.
Details
Details
Run web app, check that calendar filters work like they used to.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Are keyserver changes strictly necessary for this? I think we could do this purely on the client, but open to arguments for why we need keyserver support
Comment Actions
Also not clear to me why we need a new filter type. I guess the thinking is maybe that we would otherwise need to edit the filters whenever a new chat inside the community is created?
Comment Actions
I'm not sure if this is necessary to have this filter on keyserver, but it also shouldn't hurt.
| lib/types/filter-types.js | ||
|---|---|---|
| 16 ↗ | (On Diff #21555) | What do you think about making it more explicit that this is a community? |
Comment Actions
I'm not sure if this is necessary to have this filter on keyserver, but it also shouldn't hurt.
It hurts by introducing complexity and maintenance cost. I think we should have a good reason for why we're introducing this if we're going to do it. Passing back to @inka to discuss tradeoffs and why it makes sense to introduce this
Comment Actions
Cool, glad to see the filter removed from the server side – defer to others on the rest
Comment Actions
If this prop is specific to calendars, should we name it something more specific? It's in the global Redux state
Comment Actions
Changing this by rebasing this whole stack and changing it separately in each diff would take me over half an hour, so I hope it's fine if I do it in a separate diff - that will take me about 2min.
I know that generally we want to amend diffs, but I feel like spending so much time on changing a name would be wasteful. Please let me know if that's a wrong assumption