Page MenuHomePhabricator
Differential D6641

[9/n] Native Typeahead - Introduce SelectableTextInput
ClosedPublic
Actions

Authored by ashoat on Feb 6 2023, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 9:07 PM
Unknown Object (File)
Tue, Oct 29, 6:55 AM
Unknown Object (File)
Tue, Oct 29, 6:55 AM
Unknown Object (File)
Tue, Oct 29, 6:55 AM
Unknown Object (File)
Tue, Oct 29, 6:54 AM
Unknown Object (File)
Tue, Oct 29, 6:49 AM
Unknown Object (File)
Sep 26 2024, 7:18 AM
Unknown Object (File)
Sep 26 2024, 7:18 AM
View All 66 Files
Subscribers
None

Details

Reviewers
• przemek
tomek
atul
Commits
rCOMM51060cef3f18: [9/n] Native Typeahead - Introduce SelectableTextInput
Summary

This is just basic plumbing. Implementation comes in following diffs

Depends on D6390

Test Plan
  • Tested both iOS and Android
  • Made sure there was no flicker
  • Tested @-tag in both middle and end of text
  • Tested moving cursor after selecting @-tag

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 6 2023, 5:49 PM
ashoat added a child revision: D6642: [10/n] Native Typeahead - SelectableTextInput for Android.
Harbormaster completed remote builds in B16205: Diff 22169.Feb 6 2023, 6:04 PM
ashoat requested review of this revision.Feb 6 2023, 6:04 PM
tomek accepted this revision.Feb 7 2023, 6:00 AM
tomek added inline comments.
native/components/selectable-text-input.react.ios.js
25–32 ↗(On Diff #22169)

Nice!

This revision is now accepted and ready to land.Feb 7 2023, 6:00 AM
tomek added 1 blocking reviewer(s): • przemek.Feb 7 2023, 6:00 AM
This revision now requires review to proceed.Feb 7 2023, 6:00 AM
ashoat updated this revision to Diff 22215.Feb 7 2023, 9:11 AM

Rebase

Harbormaster completed remote builds in B16244: Diff 22215.Feb 7 2023, 10:52 AM
ashoat removed 1 blocking reviewer(s): • przemek.Feb 7 2023, 2:28 PM
This revision is now accepted and ready to land.Feb 7 2023, 2:28 PM
Closed by commit rCOMM51060cef3f18: [9/n] Native Typeahead - Introduce SelectableTextInput (authored by ashoat). · Explain WhyFeb 7 2023, 2:37 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM51060cef3f18: [9/n] Native Typeahead - Introduce SelectableTextInput.

Revision Contents
Changeset List

Diff 22215

View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/components/selectable-text-input.js

Loading...
View Options

native/components/selectable-text-input.react.ios.js

Loading...
View Options

native/components/selectable-text-input.react.js

Loading...