I can't tell from the designs if this is supposed to be "Media Gallery" or "All Media"

All wondering about the capitalization, seems inconsistent with the rest of the app but maybe it makes sense here?

What are these spaces doing here? I'm pretty sure they get ignored

1. What makes an "action header" different from a header? Should this be merged with the main header?
2. Why are we bothering to support all these categoryTypes if we're not actually using them?

Ah you're right, I missed that it changes from "Media Gallery" in the thread settings to "All Media" in the full screen gallery.

I did notice that it's inconsistent, so we could change the design here to make it "All media". I prefer "All Media" but I don't have a strong opinion either way

Yeah you're right, I'll remove the spaces in the revision and <Text>{id}</Text> will be refactored out for the actual full screen media gallery

The difference between an action header from the existing header is the actionText and onPress. The current headers have no need to support additional behavior (like text that will trigger an onPress). With the media gallery, we have the title "Media Gallery", but based on the designs we'd also need a second text component that, onPress, will navigate to the full screen gallery.

I think we could merge the two headers, it would mean making the default header accept two optional parameters actionText and onPress, and if so, conditionally render what's below, and modify the styles.header to include flexDirection: 'row',.

<TouchableOpacity onPress={props.onPress}>
          <Text style={styles.actionText}>{props.actionText}</Text>
</TouchableOpacity>

As for the three categoryType, I'm only using outline for the media gallery, but since I made the "action header" into it's own component, I thought it'd be best to support the same categoryTypes that the other two components here support, in case designs change or we want to include another ThreadSettingsCategoryActionHeader, but instead use unpadded for example like some of the other headers in the settings do

Can you check with Ted?

Got it – let's remove the unused params (including categoryType) from your new component. We can always add them later if we need them

It's usually better to type callbacks where we don't care about the return type as mixed because it is more convenient