[keyserver] Change device_token to mediumtext
ClosedPublic
Actions

Authored by michal on Feb 13 2023, 6:36 AM.

Details

Reviewers

atul
kamil
ginsu
ashoat

Commits

rCOMMa58ce8e7e3d6: [keyserver] Change device_token to mediumtext

Summary

Part of EMG-2825.

We need to save web push subscription info on the keyserver inside the device_token. Unfortunately it's too long for the current VARCHAR(255) so this diff changes that to a mediumtext. Additionaly indices had to be modified because of the the type change. Now we need to specify a prefix length that they apply to. I've tested it and it seems like registration info is 400-500 bytes so I've set it to 512.

Test Plan

Check that existing device_token rows weren't changed after running the migration
For android and ios emulators
- create a new user, check if notifications work
- run migration
- check if notifications still work

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Feb 13 2023, 6:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 13 2023, 6:36 AM

Harbormaster completed remote builds in B16386: Diff 22423.Feb 13 2023, 7:04 AM

michal requested review of this revision.Feb 13 2023, 7:04 AM

Can you amend the Test Plan to include confirming that the text wasn't visibly changed, and that iOS / Android notifs still work in the dev environment?

keyserver/src/database/migration-config.js
154 ↗	(On Diff #22423)	Can you format the JS the same as other queries in the file?
158 ↗	(On Diff #22423)	The migration above this breaks this rule, but we should stay within 80 chars
158 ↗	(On Diff #22423)	Did you verify that the text is preserved when running this migration?