Page MenuHomePhabricator
Differential D6778

Implement public method to retrieve notifications olm account public keys
ClosedPublic
Actions

Authored by marcin on Feb 20 2023, 5:05 AM.
Tags
None
Referenced Files
F3380880: D6778.id23323.diff
Thu, Nov 28, 2:48 AM
F3380747: D6778.id23310.diff
Thu, Nov 28, 1:53 AM
F3380711: D6778.id22882.diff
Thu, Nov 28, 1:39 AM
F3380443: D6778.diff
Wed, Nov 27, 11:48 PM
Unknown Object (File)
Wed, Nov 13, 4:01 AM
Unknown Object (File)
Thu, Oct 31, 4:59 PM
Unknown Object (File)
Oct 26 2024, 10:55 PM
Unknown Object (File)
Oct 26 2024, 10:55 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
atul
bartek
Commits
rCOMM2f7a72de1d41: Implement public method to retrieve notifications olm account public keys
Summary

This differential imppements public method to retrieve notifications olm account public keys. It wraps around CryptoModule::getIdentityKeys() method and adds additional check to ensure method is not called before notifications olm account is correctly initialized.

Test Plan

In CommCoreModule::initializeCryptoAccount call NotificationsCryptoAccount::initializeNotificationsCryptoAccount and then NotificationsCryptoAccount::getNotificationsIdentityKeys(). Ensure string returned is JSON containing correct olm public keys. This test is an e2e
test that also tests previous differential even more reliably.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2901
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 20 2023, 5:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 20 2023, 5:05 AM
marcin added a parent revision: D6777: Implement public method to initialize (generate and persist new) notifications olm account.Feb 20 2023, 5:06 AM
marcin added a child revision: D6779: Implement utility method to remove notifications olm account storage.Feb 20 2023, 5:15 AM
marcin published this revision for review.Feb 20 2023, 5:28 AM
Harbormaster failed remote builds in B16610: Diff 22716!Feb 20 2023, 7:58 AM
marcin updated this revision to Diff 22882.Feb 21 2023, 10:50 AM

Rebase

Harbormaster completed remote builds in B16727: Diff 22882.Feb 21 2023, 11:13 AM
bartek accepted this revision.Feb 22 2023, 12:50 AM
This revision is now accepted and ready to land.Feb 22 2023, 12:50 AM
marcin updated this revision to Diff 23256.Feb 28 2023, 10:07 AM

Rebase before landing

Harbormaster failed remote builds in B17002: Diff 23256!Feb 28 2023, 10:23 AM
Harbormaster completed remote builds in B17002: Diff 23256.Feb 28 2023, 1:34 PM
marcin updated this revision to Diff 23310.Mar 1 2023, 1:22 AM

Rebase before landing

Harbormaster completed remote builds in B17027: Diff 23310.Mar 1 2023, 1:45 AM
Closed by commit rCOMM2f7a72de1d41: Implement public method to retrieve notifications olm account public keys (authored by marcin). · Explain WhyMar 1 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM2f7a72de1d41: Implement public method to retrieve notifications olm account public keys.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
Notifications/
BackgroundDataStorage/
18 lines

Diff 22716

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...