[native] Replace settings `ThreadSettings` icon on Android
ClosedPublic
Actions

Authored by atul on Feb 20 2023, 4:18 PM.

Details

Reviewers

ginsu
rohan
tomek
marcin

Commits

rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android

Summary

Use settings icon from SWMansionIcon pack instead of whatever previous (IonIcon?) icon pack we were using.

Test Plan

Here's how it looks:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 20 2023, 4:18 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 20 2023, 4:18 PM

atul published this revision for review.Feb 20 2023, 4:19 PM

atul edited the test plan for this revision. (Show Details)

Looks good

This revision is now accepted and ready to land.Feb 20 2023, 4:22 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 20 2023, 4:25 PM

Closed by commit rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android.

Harbormaster completed remote builds in B16651: Diff 22778.Feb 20 2023, 4:34 PM

Harbormaster completed remote builds in B16652: Diff 22779.Feb 20 2023, 4:40 PM

Revision Contents
Changeset List

Path

Size

native/

chat/

thread-settings-button.react.js

10 lines

Diff 22780

View Options

native/chat/thread-settings-button.react.js

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines	:root {
--app-list-icon-enabled-color: var(--success-primary);		--app-list-icon-enabled-color: var(--success-primary);
--app-list-icon-disabled-color: var(--shades-white-80);		--app-list-icon-disabled-color: var(--shades-white-80);
--account-settings-label: var(--shades-black-60);		--account-settings-label: var(--shades-black-60);
--account-button-color: var(--violet-dark-100);		--account-button-color: var(--violet-dark-100);
--chat-thread-list-menu-color: var(--shades-white-60);		--chat-thread-list-menu-color: var(--shades-white-60);
--chat-thread-list-menu-bg: var(--shades-black-80);		--chat-thread-list-menu-bg: var(--shades-black-80);
--chat-thread-list-menu-active-color: var(--shades-white-60);		--chat-thread-list-menu-active-color: var(--shades-white-60);
--chat-thread-list-menu-active-bg: var(--shades-black-90);		--chat-thread-list-menu-active-bg: var(--shades-black-90);
		--search-clear-color: var(--shades-white-100);
		--search-clear-bg: var(--shades-black-70);
		--search-input-color: var(--shades-white-100);
		--search-input-placeholder: var(--shades-black-60);
		--search-icon-color: var(--shades-black-60);
}		}

[native] Replace settings `ThreadSettings` icon on AndroidClosedPublicActions