Page MenuHomePhabricator
Differential D6794

[native] Replace settings `ThreadSettings` icon on Android
ClosedPublic
Actions

Authored by atul on Feb 20 2023, 4:18 PM.
Tags
None
Referenced Files
F3374926: D6794.id22779.diff
Tue, Nov 26, 5:23 PM
Unknown Object (File)
Sat, Nov 23, 1:10 AM
Unknown Object (File)
Mon, Nov 11, 12:34 AM
Unknown Object (File)
Sun, Nov 10, 11:27 PM
Unknown Object (File)
Sun, Nov 10, 11:26 PM
Unknown Object (File)
Sun, Nov 10, 8:03 PM
Unknown Object (File)
Sun, Nov 10, 1:51 PM
Unknown Object (File)
Fri, Nov 1, 10:00 AM
View All Files
Subscribers
ashoat

Details

Reviewers
ginsu
rohan
tomek
marcin
Commits
rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android
Summary

Use settings icon from SWMansionIcon pack instead of whatever previous (IonIcon?) icon pack we were using.

Test Plan

Here's how it looks:

e1e90b.png (1×818 px, 124 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 20 2023, 4:18 PM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 20 2023, 4:18 PM
atul published this revision for review.Feb 20 2023, 4:19 PM
atul edited the test plan for this revision. (Show Details)
ginsu accepted this revision.Feb 20 2023, 4:22 PM

Looks good

This revision is now accepted and ready to land.Feb 20 2023, 4:22 PM
atul updated this revision to Diff 22779.Feb 20 2023, 4:25 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 20 2023, 4:25 PM
Closed by commit rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1905c532a28d: [native] Replace settings `ThreadSettings` icon on Android.
Harbormaster completed remote builds in B16651: Diff 22778.Feb 20 2023, 4:34 PM
Harbormaster completed remote builds in B16652: Diff 22779.Feb 20 2023, 4:40 PM

Revision Contents
Changeset List

PathSize
native/
chat/
10 lines

Diff 22780

View Options

native/chat/thread-settings-button.react.js

Loading...