Page MenuHomePhabricator
Differential D6490

[services] Tunnelbroker - Add disable notifications config parameter
ClosedPublic
Actions

Authored by • max on Feb 1 2023, 3:25 AM.
Tags
None
Referenced Files
F3245736: D6490.id22991.diff
Thu, Nov 14, 8:15 PM
F3245734: D6490.id21733.diff
Thu, Nov 14, 8:15 PM
F3245733: D6490.id.diff
Thu, Nov 14, 8:15 PM
Unknown Object (File)
Mon, Nov 11, 7:33 AM
Unknown Object (File)
Wed, Oct 30, 2:50 AM
Unknown Object (File)
Sep 30 2024, 7:22 PM
Unknown Object (File)
Sep 30 2024, 7:22 PM
Unknown Object (File)
Sep 30 2024, 7:22 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter
Summary

This diff introduces adding the notifications.disable config flag to disable the push notifications mechanism in a Tunnelbroker.

Linear task: ENG-2639

Test Plan

Adding the disable flag to the [notifications] section of the config file results in a true return from the isParameterSet('notifications.disable') function call.

Diff Detail

Repository
rCOMM Comm
Branch
add-skip-notifs-config
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Feb 1 2023, 3:25 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptFeb 1 2023, 3:25 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
• max added a parent revision: D6251: [services] Tunnelbroker - Add skip authentication config parameter.Feb 1 2023, 3:26 AM
• max edited parent revisions, added: D6253: [services] Tunnelbroker - Skipping session checks in a stream when `skip_authentication` flag is set; removed: D6251: [services] Tunnelbroker - Add skip authentication config parameter.Feb 1 2023, 3:36 AM
Harbormaster completed remote builds in B15922: Diff 21733.Feb 1 2023, 3:38 AM
• max published this revision for review.Feb 1 2023, 3:39 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: bartek.
• max edited the summary of this revision. (Show Details)
bartek accepted this revision.Feb 1 2023, 4:28 AM
This revision is now accepted and ready to land.Feb 1 2023, 4:28 AM
• max edited the summary of this revision. (Show Details)Feb 6 2023, 5:15 AM
• max edited the test plan for this revision. (Show Details)
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max updated this revision to Diff 22991.Feb 23 2023, 5:32 AM
• max edited the summary of this revision. (Show Details)

Rebasing on master, parent changes and D6749 fix.

• max added a child revision: D6850: [services] Tunnelbroker - Skipping sending notif token request when notifications are off by the config flag.Feb 23 2023, 5:41 AM
Harbormaster completed remote builds in B16817: Diff 22991.Feb 23 2023, 5:47 AM
Closed by commit rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter (authored by • max). · Explain WhyFeb 23 2023, 6:13 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
libcpp/
src/
Tools/
1 line
6 lines

Diff 22991

View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.h

Loading...
View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.cpp

Loading...