[keyserver] Adding metadata to the Tunnelbroker client constructor
ClosedPublic
Actions

Authored by • max on Feb 20 2023, 2:28 AM.

Details

Reviewers

varun
bartek
• jon

Commits

rCOMM31a3e54aa020: [keyserver] Adding metadata to the Tunnelbroker client constructor

Summary

This diff adds passing of the deviceID as metadata to the bidirectional stream when connecting to the Tunnelbroker through the Rust shared client library. Passing the metadata implemented by ejecting using the metadata_mut() practice.

Linear tasks:

Test Plan

Connecting to the running Tunnelbroker instance will result in a successful authentication in a reduced state (redis-replacement) mode.
When connecting without deviceID provided in the metadata the Tunnelbroker will return a following error: "Expected 'deviceID' value in metadata is not provided".

Diff Detail

Repository

rCOMM Comm

Branch

tb-client-add-metadata

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Feb 20 2023, 2:28 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 2:28 AM

• max published this revision for review.Feb 20 2023, 2:54 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, bartek.

• max added a child revision: D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.Feb 20 2023, 4:59 AM

Harbormaster failed remote builds in B16601: Diff 22707!Feb 20 2023, 6:19 AM

what is device ID in the context of tunnelbroker? just curious because we're replacing the concept of a device ID with a device public key in the Identity service

In D6771#202707, @varun wrote:

what is device ID in the context of tunnelbroker? just curious because we're replacing the concept of a device ID with a device public key in the Identity service

At the moment Tunnelbroker uses deviceID concept. I've created a follow-up task for the 0.6.
Thanks for pointing out this @varun !