Page MenuHomePhabricator
Differential D6864

[web] Link modal in the thread menu
ClosedPublic
Actions

Authored by rohan on Feb 23 2023, 10:12 AM.
Tags
None
Referenced Files
F3357241: D6864.id23268.diff
Sat, Nov 23, 10:59 PM
F3357143: D6864.id23036.diff
Sat, Nov 23, 10:36 PM
F3357091: D6864.id23023.diff
Sat, Nov 23, 10:21 PM
F3356769: D6864.diff
Sat, Nov 23, 8:38 PM
Unknown Object (File)
Mon, Nov 11, 5:17 PM
Unknown Object (File)
Mon, Nov 11, 5:07 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
ashoat
Commits
rCOMM641bc70c6e8a: [web] Link modal in the thread menu
Summary

The thread menu should allow the user to open up the media gallery.

Linear: https://linear.app/comm/issue/ENG-2879/link-modal-in-the-thread-menu

Depends on D6863

Test Plan

Confirmed that the menu appears and pushes the modal on screen

Screenshot 2023-02-23 at 1.11.13 PM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Feb 23 2023, 10:12 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 23 2023, 10:12 AM
rohan edited the test plan for this revision. (Show Details)Feb 23 2023, 10:12 AM
rohan attached a referenced file: F398972: Screenshot 2023-02-23 at 1.11.13 PM.png. (Show Details)
rohan added a child revision: D6865: [web] Allow media gallery items to click through to a full screen view on web.Feb 23 2023, 10:16 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2023, 10:19 AM
Harbormaster failed remote builds in B16842: Diff 23021!
Harbormaster completed remote builds in B16842: Diff 23021.Feb 23 2023, 10:29 AM
rohan requested review of this revision.Feb 23 2023, 10:29 AM
rohan planned changes to this revision.Feb 23 2023, 11:35 AM
rohan added inline comments.
web/chat/thread-menu.react.js
88–90

Removing this, forgot to update this on the web stack

rohan updated this revision to Diff 23023.Feb 23 2023, 11:38 AM

Remove canViewThreadMediaGallery

Harbormaster completed remote builds in B16844: Diff 23023.Feb 23 2023, 11:55 AM
ashoat added inline comments.Feb 23 2023, 12:38 PM
web/chat/thread-menu.react.js
101–102 ↗(On Diff #23023)

Don't need return keyword or curly braces

rohan updated this revision to Diff 23036.Feb 23 2023, 1:34 PM

Update formatting

Harbormaster completed remote builds in B16857: Diff 23036.Feb 23 2023, 1:52 PM
rohan added 1 blocking reviewer(s): atul.Feb 25 2023, 6:06 AM
ashoat accepted this revision.Feb 26 2023, 5:41 AM
rohan removed 1 blocking reviewer(s): atul.Feb 26 2023, 7:52 AM
This revision is now accepted and ready to land.Feb 26 2023, 7:52 AM
Closed by commit rCOMM641bc70c6e8a: [web] Link modal in the thread menu (authored by rohan). · Explain WhyFeb 28 2023, 2:05 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM641bc70c6e8a: [web] Link modal in the thread menu.

Revision Contents
Changeset List

PathSize
web/
chat/
34 lines

Diff 23021

View Options

web/chat/thread-menu.react.js

Loading...