Details

Reviewers

tomek
kamil
atul
bartek

Commits

rCOMM4e7a5cc55948: Initialize notifications olm account in CommCoreModule and expose notifications…

Summary

This differential uses NotificationsCryptoModule API to idempotently create notifications olm account and to expose notifications public keys in JS via JSI.

Test Plan

Modify one place in JS native code where we call getUserPublicKeys to log notifications public keys to the console. Example of such place is log-in panel. Launch the app and examine console.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Feb 20 2023, 6:17 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 20 2023, 6:17 AM

marcin added a parent revision: D6780: Refactor CommCoreModule.initializeCryptoAccount not to take userID as an argument..Feb 20 2023, 6:17 AM

marcin retitled this revision from Initialize noptifications olm account in CommCoreModule and expose notifications public keys to JS to Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.

marcin added 2 blocking reviewer(s): kamil, atul.

marcin published this revision for review.Feb 20 2023, 6:37 AM

Harbormaster failed remote builds in B16618: Diff 22724!Feb 20 2023, 8:47 AM

Rebase

marcin added a child revision: D6821: Implement method to sign message.Feb 21 2023, 10:41 AM

Harbormaster completed remote builds in B16718: Diff 22873.Feb 21 2023, 10:53 AM

bartek accepted this revision.Feb 23 2023, 4:44 AM

ashoat added inline comments.Feb 23 2023, 11:35 AM

native/schema/CommCoreModuleSchema.js
28–31 ↗	(On Diff #22873)	Should we update this to have a nested structure like in my Linear comment? I'm not sure it's strictly necessary if this is a client-only type, but it might be good to be consistent

Create nested notifications keys structure like on web.

Harbormaster completed remote builds in B16873: Diff 23055.Feb 24 2023, 5:21 AM

kamil accepted this revision.Feb 24 2023, 5:30 AM

ashoat added inline comments.Feb 24 2023, 3:01 PM

native/schema/CommCoreModuleSchema.js
27	I think @atul defined this type somewhere else as well, after we land both of your diffs we should dedup and move to `lib`. Can you create a task and link it here before landing?