Paths

Table of Contentst

Differential D6752

[web] Restyle search area in FilterPanel
ClosedPublic
Actions

Authored by inka on Feb 17 2023, 2:14 AM.

Tags

None

Referenced Files

	F3384232: D6752.id22934.diff
	Thu, Nov 28, 8:04 PM

	F3384091: D6752.id23462.diff
	Thu, Nov 28, 7:20 PM

	F3383746: D6752.diff
	Thu, Nov 28, 5:31 PM

	Unknown Object (File)
	Mon, Nov 25, 4:32 AM

	Unknown Object (File)
	Mon, Nov 25, 4:28 AM

	Unknown Object (File)
	Mon, Nov 25, 4:16 AM

	Unknown Object (File)
	Wed, Nov 20, 1:17 PM

	Unknown Object (File)
	Wed, Nov 20, 1:17 PM

Subscribers

Details

Reviewers

michal
kamil
• kuba

Commits

rCOMM64ece713fb17: [web] Restyle search area in FilterPanel

Summary

Issue: https://linear.app/comm/issue/ENG-3014/add-a-button-to-close-the-filter-panel
There is supposed to be a button for closing the filter panel, inside of the filter panel. Additionally some styles around it were changed, so I changed them as well to keep the panel looking consistent. Note that in the issues comments it had been decided to keep the search bars background colour consistent with the rest of the app for now.
The filters buttnon (the one used for opening) is supposed to disappear when the panel is open

image.png (358×568 px, 26 KB)

Test Plan

run web app, checked that items in the filter panel display correctly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Feb 17 2023, 2:14 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 17 2023, 2:14 AM

inka edited the summary of this revision. (Show Details)Feb 17 2023, 2:15 AM

Make the button close the panel - it turned out it required very little changes, so amending to this diff

Harbormaster completed remote builds in B16566: Diff 22667.Feb 17 2023, 2:29 AM

inka edited the summary of this revision. (Show Details)Feb 17 2023, 2:30 AM

inka edited the summary of this revision. (Show Details)

inka attached a referenced file: F384781: Screen Recording 2023-02-17 at 11.30.11.mov. (Show Details)

Harbormaster completed remote builds in B16567: Diff 22668.Feb 17 2023, 2:41 AM

inka requested review of this revision.Feb 17 2023, 2:41 AM

Rebase

Harbormaster failed remote builds in B16686: Diff 22819!Feb 21 2023, 3:24 AM

Rebase

Harbormaster failed remote builds in B16706: Diff 22859!Feb 21 2023, 7:31 AM

Apply new prettier rules

Harbormaster completed remote builds in B16773: Diff 22934.Feb 22 2023, 9:43 AM

inka added inline comments.Feb 23 2023, 5:25 AM

web/calendar/filter-panel.css
9–10 ↗	(On Diff #22934)	Will fix this
133–134 ↗	(On Diff #22934)	Will fix this

Use values from typography.css

Harbormaster completed remote builds in B16821: Diff 22995.Feb 23 2023, 6:00 AM

michal accepted this revision.Mar 2 2023, 3:00 AM

michal added inline comments.

web/calendar/calendar.react.js
167 ↗	(On Diff #22995)	Instead of changing the style, can we conditionally render the filter button?

This revision is now accepted and ready to land.Mar 2 2023, 3:00 AM

Address review

Harbormaster completed remote builds in B17127: Diff 23462.Mar 6 2023, 4:55 AM

Closed by commit rCOMM64ece713fb17: [web] Restyle search area in FilterPanel (authored by • InkaSokolowska). · Explain WhyMar 6 2023, 6:57 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM64ece713fb17: [web] Restyle search area in FilterPanel.

Revision Contents
Changeset List

Path

Size

web/

calendar/

calendar.react.js

19 lines

filter-panel.css

36 lines

filter-panel.react.js

19 lines

2 lines

Diff 23464

web/calendar/calendar.react.js

Loading...

web/calendar/filter-panel.css

Loading...

web/calendar/filter-panel.react.js

Loading...

web/theme.css

Loading...