Page MenuHomePhabricator

[lib] Add deviceTypes constant for enumerating all valid mobile device types
ClosedPublic

Authored by ashoat on Mar 7 2023, 7:32 AM.
Tags
None
Referenced Files
F1785304: D6982.id23519.diff
Sat, May 18, 2:36 PM
F1785222: D6982.id.diff
Sat, May 18, 1:47 PM
F1782904: D6982.id23498.diff
Sat, May 18, 9:01 AM
Unknown Object (File)
Sat, May 11, 1:45 PM
Unknown Object (File)
Sat, May 11, 1:45 PM
Unknown Object (File)
Sat, May 11, 1:45 PM
Unknown Object (File)
Sat, May 11, 6:12 AM
Unknown Object (File)
Fri, May 10, 8:33 PM
Subscribers

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested review of this revision.Mar 7 2023, 7:48 AM
This revision is now accepted and ready to land.Mar 7 2023, 10:22 AM
This comment was removed by varun.

Not sure what you mean – deviceTypesObj can't be extended outside of this file since it's not exported. We're actually using Object.freeze for Flow, otherwise $Values<typeof deviceTypesObj> maps to string instead of 'ios' | 'android'

oh nvm, i’ll delete my comment