Page MenuHomePhabricator
Differential D6997

[keyserver] add new compareUsers function to rust-node-addon
ClosedPublic
Actions

Authored by varun on Mar 7 2023, 10:07 AM.
Tags
None
Referenced Files
F3511995: D6997.id23515.diff
Sat, Dec 21, 5:46 PM
F3509744: D6997.diff
Sat, Dec 21, 7:55 AM
Unknown Object (File)
Wed, Dec 4, 7:06 AM
Unknown Object (File)
Wed, Dec 4, 7:06 AM
Unknown Object (File)
Wed, Dec 4, 7:06 AM
Unknown Object (File)
Wed, Dec 4, 6:47 AM
Unknown Object (File)
Nov 12 2024, 12:10 PM
Unknown Object (File)
Oct 28 2024, 10:17 PM
View All 94 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
• jon
Commits
rCOMMfc69c7467481: [keyserver] add new compareUsers function to rust-node-addon
Summary

adding a new function that just calls the compareUsers RPC and returns a userComparisonResult, containing two arrays: usersMissingFromKeyserver and usersMissingFromIdentity

Depends on D6984

Test Plan

this gets tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 7 2023, 10:07 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMar 7 2023, 10:07 AM
varun published this revision for review.Mar 7 2023, 10:18 AM
varun added a child revision: D6998: [keyserver] update compare-user.js to get missing users by querying identity service.
Harbormaster completed remote builds in B17173: Diff 23515.Mar 7 2023, 10:23 AM
ashoat accepted this revision.Mar 7 2023, 10:51 AM
ashoat added 1 blocking reviewer(s): • jon.

JS looks good with some minor nits. Somebody should look at Rust

lib/types/rust-binding-types.js
18 ↗(On Diff #23515)

Types are always capitalized

19–20 ↗(On Diff #23515)

We should generally use $ReadOnlyArray unless we have a good reason not to, especially when it's in combination with + (read-only access modifier)

• jon added inline comments.Mar 7 2023, 11:01 AM
keyserver/addons/rust-node-addon/src/identity_client/compare_users.rs
18 ↗(On Diff #23515)

Personal nit: but I would love for some white space to break up logical sections. Here we have "setup" and "action"

• jon accepted this revision.Mar 7 2023, 11:02 AM
This revision is now accepted and ready to land.Mar 7 2023, 11:02 AM
Closed by commit rCOMMfc69c7467481: [keyserver] add new compareUsers function to rust-node-addon (authored by varun). · Explain WhyMar 7 2023, 2:32 PM
This revision was automatically updated to reflect the committed changes.
varun marked 3 inline comments as done.
varun added a commit: rCOMMfc69c7467481: [keyserver] add new compareUsers function to rust-node-addon.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
36 lines
5 lines
lib/
types/
8 lines

Diff 23522

View Options

keyserver/addons/rust-node-addon/src/identity_client/compare_users.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

lib/types/rust-binding-types.js

Loading...