Page MenuHomePhabricator
Differential D7028

[Identity] Change default port to 50054 to avoid port collision
ClosedPublic
Actions

Authored by • jon on Mar 9 2023, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 6:24 AM
Unknown Object (File)
Tue, Oct 29, 6:21 AM
Unknown Object (File)
Wed, Oct 23, 1:11 AM
Unknown Object (File)
Sun, Oct 20, 8:33 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision
Summary

Avoid future port testing or deployment conflicts
by defaulting port something other than default grpc port.

https://linear.app/comm/issue/ENG-3289

Test Plan

Run identity service, keyserver, and native yarn dev

Create new user. Verify identity service is responding.

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/identity-default-port
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Mar 9 2023, 3:53 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 9 2023, 3:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 9 2023, 4:00 PM
Harbormaster failed remote builds in B17229: Diff 23597!
• jon added inline comments.Mar 9 2023, 4:13 PM
services/identity/src/main.rs
61 ↗(On Diff #23597)

Just added this because it's pretty jarring to get 0 output initially.

Harbormaster completed remote builds in B17229: Diff 23597.Mar 9 2023, 4:16 PM
• jon requested review of this revision.Mar 9 2023, 4:16 PM
bartek accepted this revision.Mar 9 2023, 10:55 PM
This revision is now accepted and ready to land.Mar 9 2023, 10:55 PM
varun accepted this revision.Mar 9 2023, 10:59 PM
varun added inline comments.
services/identity/src/main.rs
61 ↗(On Diff #23597)

nit: gRPC

• jon updated this revision to Diff 23608.Mar 10 2023, 8:27 AM
• jon marked an inline comment as done.

grpc -> gRPC

Harbormaster completed remote builds in B17238: Diff 23608.Mar 10 2023, 8:42 AM
• jon added inline comments.Mar 10 2023, 9:00 AM
services/identity/src/main.rs
61 ↗(On Diff #23597)

fair

• jon updated this revision to Diff 23610.Mar 10 2023, 9:03 AM

Rebase on master

Harbormaster completed remote builds in B17240: Diff 23610.Mar 10 2023, 9:18 AM
Closed by commit rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision (authored by • jon). · Explain WhyMar 10 2023, 9:22 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
2 lines
services/
2 lines
identity/
src/
2 lines
2 lines

Diff 23608

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

services/docker-compose.yml

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/main.rs

Loading...