Found the logging to be kind of annoying. Would prefer if Nix/Direnv worked completely in the background. Realize this is a personal preference so this change won't affect anyone unless they explicitly set COMM_NIX_LOGGING_LEVEL="none".
Details
Details
Before setting COMM_NIX_LOGGING_LEVEL:
After setting COMM_NIX_LOGGING_LEVEL="none":
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D7052 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| .envrc | ||
|---|---|---|
| 11–15 ↗ | (On Diff #23657) | I don't know bash so let me definitely know if there's something I'm missing or there's an obviously better way to do this |
| .envrc | ||
|---|---|---|
| 11–16 ↗ | (On Diff #23657) | bash doesn't have a set "boolean" value pair. Generally you see people setting a variable to nothing VAR= or unset VAR for false values; and setting it to anything else to be true VAR=1 |
| .envrc | ||
|---|---|---|
| 11–16 ↗ | (On Diff #23657) | Ah was hoping for this to be more of an "enum" than a "boolean." As in we might have "none", "error", "verbose", etc. in the future? I wanted wanted to maintain the default behavior so I didn't want COMM_NIX_LOGGING_LEVEL being unset to disable logs. I wanted disabled logs to be opt-in, so I set COMM_NIX_LOGGING_LEVEL to "something" (in this case "none") in order to toggle that. |
| .envrc | ||
|---|---|---|
| 11–16 ↗ | (On Diff #23657) | Then I would invert the intention: COMM_NIX_QUIET=1 |
| .envrc | ||
|---|---|---|
| 11–16 ↗ | (On Diff #23657) | gotcha, will update this diff and use SUPPRESS_COMM_NIX_LOGGING as the environment variable instead |