We want to show the notif permission modal on web less often and we can reuse NotifPermissionAlertInfo for this. This diff moves it from native redux to the shared redux setup and the base reducer. The next diff will actually use it on web.
Details
Details
- Reviewers
inka tomek - Commits
- rCOMM350edf6e7f6d: [native] Move NotifPermissionAlertInfo to lib
Check if redux is correctly updated after showing the alerts on native. Test both a fresh device and when updating. The web was tested with the next diff, and it also correctly updates redux.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks ok - it doesn't seem necessary to do a migration.
A test plan should include more checks:
- does it work on web?
- does it work on fresh native?
- does it work when updating native?
I'm not sure but only 2nd or 3rd is covered by the current test plan.