Page MenuHomePhabricator

[Native] Migrate native_rust_library to use identity client stubs
ClosedPublic

Authored by jon on Mar 23 2023, 10:26 AM.
Tags
None
Referenced Files
F3299548: D7155.id24207.diff
Sun, Nov 17, 1:29 PM
Unknown Object (File)
Fri, Nov 8, 9:52 AM
Unknown Object (File)
Thu, Nov 7, 4:30 AM
Unknown Object (File)
Wed, Nov 6, 3:17 AM
Unknown Object (File)
Tue, Nov 5, 1:58 AM
Unknown Object (File)
Mon, Nov 4, 11:19 PM
Unknown Object (File)
Mon, Nov 4, 11:19 PM
Unknown Object (File)
Mon, Nov 4, 11:19 PM
Subscribers

Details

Summary

The existing bindings used the now "keyserver" API, and we
need to migrate the usage to the newer client gRPC API.

In addition, decided to update the reference of comm-opaque to use
the opaque_ke 2.0 comm-opaque2 project

https://linear.app/comm/issue/ENG-3384

Test Plan

This will be tested thoroughly in later diffs, for now this is
intended to allow for division of work between implmenting the different RPCs

cd native/native_rust_library
cargo build

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/split-key-rpcs (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/native_rust_library/build.rs
16–17

tonic_build automatically does this for us.

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 23 2023, 11:03 AM
Harbormaster failed remote builds in B17557: Diff 24034!

Move wasm generation into web/

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 27 2023, 8:00 AM
Harbormaster failed remote builds in B17681: Diff 24204!

Undo changes to android CMakeLists.txt

web/opaque-ke-wasm/src/lib.rs
1 ↗(On Diff #24207)

This allows for wasm-pack build to pick up the relevant things we want to export

web/opaque-ke-wasm/Cargo.toml
6–7 ↗(On Diff #24207)

Moving the wasm-specific crate-types was necessary because corrosion-rs tries to build for these crate-types as well, which don't work as well.

Having this in a separate directory allows for some separation of concerns; and makes corrosion-rs able to proceed with the happy path which works currently.

Thanks for submitting!! I am clueless in Rust and this appears mostly Rust, so I will resign

This revision is now accepted and ready to land.Mar 27 2023, 1:45 PM