[keyserver] Compose encrypted media messages
ClosedPublic
Actions

Authored by bartek on Mar 24 2023, 5:59 AM.

Details

Reviewers

rohan
atul
marcin

Commits

rCOMM6a986cc389b5: [keyserver] Compose encrypted media messages

Summary

Part of ENG-3393

This diff implements composing encrypted messages on keyserver, basing of existence of the encryptionKey field in uploads table.

Depends on D7170
Depends on D7167

Test Plan

This code was actually used to test previous diffs. At this point, multimedia containing encryptionKey field in extras column of uploads table should be shimmed properly

Diff Detail

Repository

rCOMM Comm

Branch

barthap/encrypted-media/js

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 24 2023, 5:59 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 24 2023, 5:59 AM

Harbormaster completed remote builds in B17585: Diff 24073.Mar 24 2023, 6:14 AM

Fix typo in variable name

Harbormaster completed remote builds in B17586: Diff 24074.Mar 24 2023, 6:55 AM

bartek published this revision for review.Mar 27 2023, 5:57 AM

The logic seems good to me

keyserver/src/fetchers/upload-fetchers.js
325 ↗	(On Diff #24074)	I'd prefer if (loop) { media.push({ ...video, loop}); } else { media.push(video); } but it's more of a personal preference to avoid a ternary here, so feel free to keep it as is