This diff implements native methods to manage media cache stored in filesystem: the tmp_dir/media-cache directory.
Depends on D7251
Details
Details
Tested together with parent diff - saved some files to cache and then retrieved it. It is possible to print the cache path and open it with Finder to inspect what files are inside.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/media/file-utils.js | ||
|---|---|---|
| 203 | Should the first param be a RegExp to make sure it doesn't replace other parts of the filename? Not sure this works, but something like new RegExp(`.${extension}$`) | |
| native/media/media-cache.js | ||
| 1 | Nit: add extra newline here | |
| 30 | Nit: add newline here | |
| 33–34 | Nit | |
| 69 | Can we extract this RegExp object and assign it to a variable in the global scope to avoid recreating it every time? | |
| lib/media/file-utils.js | ||
|---|---|---|
| 203 | Good point | |
Comment Actions
Please escape the . character in the RegExp before landing! Sorry I didn't notice this in my suggestion
| lib/media/file-utils.js | ||
|---|---|---|
| 203 ↗ | (On Diff #24483) | The . character here matches anything, so eg. if you mean to replace test.blah -> test`, you could accidentally replace test.zblah -> test.. I think we can escape the . character to avoid this |