[lib] Add function to calculate padding size
ClosedPublic
Actions

Authored by bartek on Mar 28 2023, 11:01 AM.

Details

Reviewers

atul
marcin

Commits

rCOMM2ae7fd240fe1: [lib] Add function to calculate padding size

Summary

This diff adds a function to calculate file size after padding. It will be used in subsequent diffs.
The content is basically copied from actual padding functions.

Test Plan

Added unit test

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 28 2023, 11:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2023, 11:01 AM

Harbormaster completed remote builds in B17755: Diff 24298.Mar 28 2023, 11:17 AM

bartek published this revision for review.Mar 28 2023, 11:35 AM

Thanks for including a test (and adding a comment explaining what's happening)

lib/utils/pkcs7-padding.js
41–45 ↗	(On Diff #24298)	I think usually we'd do something like this, but don't feel too strongly. (cc @ashoat)

This revision is now accepted and ready to land.Mar 28 2023, 3:54 PM

ashoat added inline comments.Mar 28 2023, 6:25 PM

lib/utils/pkcs7-padding.js
41–45 ↗	(On Diff #24298)	I'm okay either way. Agree that @bartek's usage is more rare, but it's not too unclear

bartek added a child revision: D7233: [lib][native] Add function to encrypt files.Mar 29 2023, 6:50 AM

Rebase before landing

Harbormaster completed remote builds in B17824: Diff 24397.Mar 30 2023, 7:40 AM

Closed by commit rCOMM2ae7fd240fe1: [lib] Add function to calculate padding size (authored by bartek). · Explain WhyMar 30 2023, 9:39 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM2ae7fd240fe1: [lib] Add function to calculate padding size.

Revision Contents
Changeset List

Path

Size

lib/

utils/

pkcs7-padding.js

23 lines

pkcs7-padding.test.js

23 lines

Diff 24397

View Options

lib/utils/pkcs7-padding.js