Paths

Table of Contentst

Differential D7230

[lib] Add option to force-create multimedia-type message
ClosedPublic
Actions

Authored by bartek on Mar 28 2023, 12:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 10:14 PM

	Unknown Object (File)
	Tue, Nov 12, 8:14 PM

	Unknown Object (File)
	Tue, Nov 12, 4:58 PM

	Unknown Object (File)
	Tue, Nov 12, 4:27 PM

	Unknown Object (File)
	Tue, Nov 12, 1:22 PM

	Unknown Object (File)
	Tue, Nov 12, 12:52 PM

	Unknown Object (File)
	Fri, Nov 8, 3:34 AM

	Unknown Object (File)
	Mon, Nov 4, 3:29 AM

Subscribers

Details

Reviewers

ashoat
atul
marcin

Commits

rCOMM821c609a2517: [lib] Add option to force-create multimedia-type message

Summary

Currently, when creating a new multimedia message, it's type is based on content. If there are only photos, then it is set to PHOTOS (14). If it contains one or more videos, then it is set to MULTIMEDIA (15).
For encrypted photos, the type should always be MULTIMEDIA. This diff adds an option to force this setting.

Test Plan

Set this option to true in the callsite inside input-state-container. Then sent a message. Ensured that this message has type 15 in both Redux and keyserver database.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 28 2023, 12:47 PM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2023, 12:47 PM

Harbormaster completed remote builds in B17768: Diff 24314.Mar 28 2023, 1:03 PM

bartek published this revision for review.Mar 28 2023, 1:25 PM

ashoat accepted this revision.Mar 28 2023, 1:46 PM

This revision is now accepted and ready to land.Mar 28 2023, 1:46 PM

Rebase before landing

Harbormaster completed remote builds in B17826: Diff 24399.Mar 30 2023, 7:41 AM

bartek added a child revision: D7236: [native] Encrypt files during media mission.Mar 30 2023, 9:36 AM

Closed by commit rCOMM821c609a2517: [lib] Add option to force-create multimedia-type message (authored by bartek). · Explain WhyMar 30 2023, 9:39 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM821c609a2517: [lib] Add option to force-create multimedia-type message.

bartek mentioned this in D7291: [keyserver] Support encrypted media in create_multimedia_message.Apr 6 2023, 5:49 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

13 lines

Diff 24399

lib/shared/message-utils.js

Loading...