[lib][web][native] Introduce commServicesAccessToken to Redux state
ClosedPublic
Actions

Authored by ashoat on Mar 27 2023, 8:11 PM.

Details

Reviewers

kamil
varun
• jon
atul

Commits

rCOMM36ec83e43d51: [lib][web][native] Introduce commServicesAccessToken to Redux state

Summary

We'll use this to track the access token used to authenticate the client to Comm services.

Test Plan

I just tested this with Flow for now, but I'll test it more thoroughly in combination with the following diffs, and will wait to land it until then

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 27 2023, 8:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2023, 8:11 PM

Add to redux-persist allowlist on native

Harbormaster completed remote builds in B17719: Diff 24254.Mar 27 2023, 8:27 PM

Harbormaster completed remote builds in B17720: Diff 24255.

ashoat requested review of this revision.Mar 27 2023, 8:28 PM

LGTM, ill defer to react/redux people for correctness

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

This revision is now accepted and ready to land.Mar 28 2023, 1:27 PM

In D7212#214878, @atul wrote:

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

No reason to do that, I think... it would just set commServicesAccessToken to null, but state.commServicesAccessToken already returns undefined...

There will be follow-up diffs here for the reducer etc., though

True that makes sense

Closed by commit rCOMM36ec83e43d51: [lib][web][native] Introduce commServicesAccessToken to Redux state (authored by ashoat). · Explain WhyApr 3 2023, 7:31 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM36ec83e43d51: [lib][web][native] Introduce commServicesAccessToken to Redux state.