[web] Add function to encrypt media file
ClosedPublic
Actions

Authored by bartek on Apr 3 2023, 2:10 PM.

Details

Reviewers

atul
marcin

Commits

rCOMM054053479a0e: [web] Add function to encrypt media file

Summary

Add function that encrypts given File.

Depends on D7268

Test Plan

Tested together with child diffs

Diff Detail

Repository

rCOMM Comm

Branch

barthap/encrypted-media/js

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 3 2023, 2:10 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2023, 2:10 PM

bartek added a child revision: D7294: [web] Encrypt media before uploading.Apr 3 2023, 2:24 PM

Harbormaster completed remote builds in B17951: Diff 24586.Apr 3 2023, 2:29 PM

bartek published this revision for review.Apr 3 2023, 2:31 PM

Looks good, would've been helpful to have a few more specifics in the Test Plan

web/media/encryption-utils.js
33	Thanks for annotating the steps with comments, makes the code much easier to follow.

This revision is now accepted and ready to land.Apr 4 2023, 10:13 AM

atul added inline comments.Apr 4 2023, 10:13 AM

web/media/encryption-utils.js
78	Maybe `Step 3: Write encrypted file to disk` or something?

Add missing step comment

Harbormaster completed remote builds in B18040: Diff 24713.Apr 6 2023, 6:15 AM

Closed by commit rCOMM054053479a0e: [web] Add function to encrypt media file (authored by bartek). · Explain WhyApr 6 2023, 6:19 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM054053479a0e: [web] Add function to encrypt media file.

Revision Contents
Changeset List

Path

Size

web/

media/

encryption-utils.js

83 lines

Diff 24586

View Options

web/media/encryption-utils.js

[web] Add function to encrypt media fileClosedPublicActions