This diff modifies the <Multimedia> component to be able to display encrypted media.
The type and uri props are replaced by a single object representing an encrypted or non-encrypted media.
Depends on D7280
Details
Details
Both encrypted and decrypted media are displayed in the chat. Clicking on them opens a modal.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think the condition at web/media/multimedia.react.js:52-53 was intended to be || instead of &&?
Feel free to re-request review if I'm mistaken about something
| web/media/multimedia.react.js | ||
|---|---|---|
| 52–53 ↗ | (On Diff #24559) | Did you intend this to be || instead of &&? I don't believe the condition here is "reachable?" |
| web/media/multimedia.react.js | ||
|---|---|---|
| 52–53 ↗ | (On Diff #24559) | Indeed, good catch! |