Page MenuHomePhabricator
Differential D7281

[web] Support encrypted media in <Multimedia>
ClosedPublic
Actions

Authored by bartek on Apr 3 2023, 3:19 AM.
Tags
None
Referenced Files
F3628224: D7281.diff
Thu, Jan 2, 7:08 PM
Unknown Object (File)
Sat, Dec 14, 4:49 PM
Unknown Object (File)
Sat, Dec 14, 4:49 PM
Unknown Object (File)
Sat, Dec 14, 4:49 PM
Unknown Object (File)
Sat, Dec 14, 4:48 PM
Unknown Object (File)
Sat, Dec 14, 4:43 PM
Unknown Object (File)
Thu, Dec 12, 7:57 PM
Unknown Object (File)
Thu, Dec 5, 8:41 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
marcin
inka
ginsu
Commits
rCOMM121ce199f134: [web] Support encrypted media in <Multimedia>
Summary

This diff modifies the <Multimedia> component to be able to display encrypted media.
The type and uri props are replaced by a single object representing an encrypted or non-encrypted media.

Depends on D7280

Test Plan

Both encrypted and decrypted media are displayed in the chat. Clicking on them opens a modal.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Apr 3 2023, 3:19 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2023, 3:19 AM
Harbormaster completed remote builds in B17929: Diff 24559.Apr 3 2023, 3:34 AM
bartek published this revision for review.Apr 3 2023, 4:57 AM
bartek added a child revision: D7292: [web] Add encryptionKey to PendingMultimediaUpload.Apr 3 2023, 1:27 PM
atul requested changes to this revision.Apr 4 2023, 9:27 AM

I think the condition at web/media/multimedia.react.js:52-53 was intended to be || instead of &&?

Feel free to re-request review if I'm mistaken about something

web/media/multimedia.react.js
52–53 ↗(On Diff #24559)

Did you intend this to be || instead of &&?

I don't believe the condition here is "reachable?"

This revision now requires changes to proceed.Apr 4 2023, 9:27 AM
bartek added inline comments.Apr 6 2023, 5:54 AM
web/media/multimedia.react.js
52–53 ↗(On Diff #24559)

Indeed, good catch!

bartek updated this revision to Diff 24711.Apr 6 2023, 5:54 AM

Fix conditional

Harbormaster completed remote builds in B18038: Diff 24711.Apr 6 2023, 6:10 AM
atul accepted this revision.Apr 6 2023, 7:48 AM
This revision is now accepted and ready to land.Apr 6 2023, 7:48 AM
Closed by commit rCOMM121ce199f134: [web] Support encrypted media in <Multimedia> (authored by bartek). · Explain WhyApr 6 2023, 7:52 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM121ce199f134: [web] Support encrypted media in <Multimedia>.

Revision Contents
Changeset List

PathSize
web/
chat/
6 lines
22 lines
media/
71 lines

Diff 24733

View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/multimedia-message.react.js

Loading...
View Options

web/media/multimedia.react.js

Loading...