This diff modifies the <MultimediaModal> component to be able to display encrypted media.
The type and uri props are replaced by a single object representing an encrypted or non-encrypted media.
Depends on D7279
Details
Details
Clicking on both encrypted and non-encrypted photo (the latter one possible together with the child diff) opens a modal and displays media.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks great!
| web/media/multimedia-modal.react.js | ||
|---|---|---|
| 19 ↗ | (On Diff #24558) | I think this was mentioned somewhere else, but did we conclude that EncryptedMediaType isn't "sensitive" and doesn't leak anything? |
| 53–55 ↗ | (On Diff #24558) | This is to be removed in the future, right? |
| web/modals/threads/gallery/thread-settings-media-gallery.react.js | ||
| 51 ↗ | (On Diff #24558) | Thanks for flagging this! Nit: I think we typically try to keep comments sentence-like. There are quite a few places where we omit ending punctuation (period, question mark, etc), but might be worth at least capitalizing "this". |
| web/media/multimedia-modal.react.js | ||
|---|---|---|
| 19 ↗ | (On Diff #24558) | Yeah, it's just a subset of MediaType enum |
| 53–55 ↗ | (On Diff #24558) | We support only 4 vaiues for now: photo, video and encrypted_{photo,video}. If it isn't any of them, then it's illegal value. |