[lib] Move `invariant` in `changeThreadSettings` above `callServerEndpoint`
ClosedPublic
Actions

Authored by atul on Apr 4 2023, 1:05 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM7695313d1dab: [lib] Move `invariant` in `changeThreadSettings` above `callServerEndpoint`

Summary

Unless I'm mistaken, it makes more sense to check this before we make a call to the keyserver?

Test Plan

Things continue to work as expected, we don't expect to see this invariant hit.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7305 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 4 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2023, 1:05 PM

atul published this revision for review.Apr 4 2023, 1:05 PM

atul added inline comments.

lib/actions/thread-actions.js
52–55 ↗	(On Diff #24641)	`invariant` was initially introduced in this commit: https://github.com/CommE2E/comm/commit/33450093aec86d4dc086ae2957ef2111ce9ebef6

Harbormaster completed remote builds in B17987: Diff 24641.Apr 4 2023, 1:21 PM

I'm guessing it was put there because it's only there to prevent Flow errors in the return, but this is fine

This revision is now accepted and ready to land.Apr 4 2023, 1:44 PM

land

This revision was landed with ongoing or failed builds.Apr 5 2023, 7:13 AM

Closed by commit rCOMM7695313d1dab: [lib] Move `invariant` in `changeThreadSettings` above `callServerEndpoint` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7695313d1dab: [lib] Move `invariant` in `changeThreadSettings` above `callServerEndpoint`.

Harbormaster completed remote builds in B18003: Diff 24663.Apr 5 2023, 7:29 AM

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

2 lines

Diff 24663

View Options

lib/actions/thread-actions.js

[lib] Move `invariant` in `changeThreadSettings` above `callServerEndpoint`ClosedPublicActions