[lib][native] Deprecate unshimMessageStore
ClosedPublic
Actions

Authored by ashoat on Apr 6 2023, 2:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 14, 8:41 AM

	Unknown Object (File)
	Tue, Dec 31, 7:09 PM

	Unknown Object (File)
	Tue, Dec 31, 7:09 PM

	Unknown Object (File)
	Tue, Dec 31, 7:08 PM

	Unknown Object (File)
	Tue, Dec 31, 7:01 PM

	Unknown Object (File)
	Dec 13 2024, 10:38 PM

	Unknown Object (File)
	Dec 2 2024, 7:38 AM

	Unknown Object (File)
	Dec 2 2024, 7:32 AM

View All 74 Files

Subscribers

tomek

Details

Reviewers

atul
kamil
bartek

Commits

rCOMMbd05e90ad757: [lib][native] Deprecate unshimMessageStore

Summary

I want to make it clear that this function shouldn't be used. It doesn't work in the new SQLite world.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/media

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 6 2023, 2:07 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 2:07 PM

Harbormaster completed remote builds in B18063: Diff 24750.Apr 6 2023, 2:24 PM

ashoat requested review of this revision.Apr 6 2023, 2:24 PM

atul accepted this revision.Apr 6 2023, 2:25 PM

This revision is now accepted and ready to land.Apr 6 2023, 2:25 PM

ashoat added a child revision: D7338: [native] Extract unshimClientDB into function.Apr 7 2023, 4:25 AM

Closed by commit rCOMMbd05e90ad757: [lib][native] Deprecate unshimMessageStore (authored by ashoat). · Explain WhyApr 7 2023, 6:04 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbd05e90ad757: [lib][native] Deprecate unshimMessageStore.

Revision Contents
Changeset List

Path

Size

lib/

shared/

unshim-utils.js

4 lines

native/

redux/

persist.js

13 lines

Diff 24750

View Options

lib/shared/unshim-utils.js