Paths

Table of Contentst

Differential D7373

[native] change outerRingSelectedColor prop type from string to ViewStyle
ClosedPublic
Actions

Authored by ginsu on Apr 10 2023, 11:45 AM.

Tags

None

Referenced Files

	F3400213: D7373.id24930.diff
	Mon, Dec 2, 6:38 AM

	F3400188: D7373.id24913.diff
	Mon, Dec 2, 6:33 AM

	F3400027: D7373.id24933.diff
	Mon, Dec 2, 5:54 AM

	F3399562: D7373.diff
	Mon, Dec 2, 3:47 AM

	Unknown Object (File)
	Tue, Nov 5, 4:49 AM

	Unknown Object (File)
	Tue, Nov 5, 4:49 AM

	Unknown Object (File)
	Tue, Nov 5, 4:49 AM

	Unknown Object (File)
	Tue, Nov 5, 4:49 AM

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMMc1ec9c0a5ec7: [native] change outerRingSelectedColor prop type from string to ViewStyle

Summary

Based on a comment I got on D7323 it would be better to have the outerRingSelectedColor prop type be a ViewStyle so that we can use a color entry from color.js instead of picking a color in the EmojiAvatarCreation component, which will help maintain a consistent design system

Depends on D7353

Test Plan

Tested the selected color outer ring in ColorSelectors and EmojiAvatarCreation and got the following in light and dark mode:

ColorSelectors (does not use the outerRingSelectedColor prop):

Dark:

Screenshot 2023-04-10 at 2.37.54 PM.png (1×1 px, 808 KB)

Light:

Screenshot 2023-04-10 at 2.37.39 PM.png (1×1 px, 814 KB)

EmojiAvatarCreation: (used modalSubtext entry from colors.js as the outerRingSelectedColor prop)

Dark:

Screenshot 2023-04-10 at 2.37.11 PM.png (1×1 px, 787 KB)

Light:

Screenshot 2023-04-10 at 2.37.24 PM.png (1×1 px, 796 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 10 2023, 11:45 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 10 2023, 11:45 AM

ginsu edited the summary of this revision. (Show Details)Apr 10 2023, 11:48 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7353: [native] changed name of loginText to whiteText.

ginsu attached a referenced file: F476261: Screenshot 2023-04-10 at 2.37.24 PM.png. (Show Details)

ginsu attached a referenced file: F476260: Screenshot 2023-04-10 at 2.37.11 PM.png. (Show Details)

ginsu attached a referenced file: F476259: Screenshot 2023-04-10 at 2.37.39 PM.png. (Show Details)

ginsu attached a referenced file: F476258: Screenshot 2023-04-10 at 2.37.54 PM.png. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added a child revision: D7323: [native] introduce emoji avatar creation screen.Apr 10 2023, 11:51 AM

Harbormaster completed remote builds in B18193: Diff 24913.Apr 10 2023, 12:02 PM

ginsu requested review of this revision.Apr 10 2023, 12:02 PM

ashoat accepted this revision.Apr 10 2023, 12:04 PM

This revision is now accepted and ready to land.Apr 10 2023, 12:04 PM

rebase before landing

Harbormaster completed remote builds in B18206: Diff 24930.Apr 10 2023, 3:38 PM

Closed by commit rCOMMc1ec9c0a5ec7: [native] change outerRingSelectedColor prop type from string to ViewStyle (authored by ginsu). · Explain WhyApr 10 2023, 8:45 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMc1ec9c0a5ec7: [native] change outerRingSelectedColor prop type from string to ViewStyle.

Revision Contents
Changeset List

Path

Size

native/

components/

color-rows.react.js

9 lines

color-selector-button.react.js

11 lines

Diff 24913

native/components/color-rows.react.js

Loading...

native/components/color-selector-button.react.js

Loading...