[native] Add CommUtilsModule spec
ClosedPublic
Actions

Authored by bartek on Apr 14 2023, 5:26 AM.

Details

Reviewers

ashoat
atul
marcin
kamil

Commits

rCOMMb96b35d54c19: [native] Add CommUtilsModule spec

Summary

As a part of ENG-3408 I decided to introduce a separate TurboModule for C++ utilities to avoid bloating CommCoreModule.

Test Plan

This diff is tested together with the child one that runs jsi-codegen.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 14 2023, 5:26 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptApr 14 2023, 5:26 AM

bartek added a child revision: D7450: [native][codegen] Generate CommUtilsModule C++ spec.Apr 14 2023, 5:29 AM

bartek published this revision for review.Apr 14 2023, 5:43 AM

Harbormaster completed remote builds in B18366: Diff 25160.Apr 14 2023, 5:44 AM

ashoat accepted this revision.Apr 14 2023, 5:47 AM

ashoat added inline comments.

native/schema/CommUtilsModuleSchema.js
9	Doesn't really matter, but this might be a good use case for an "opaque type"

This revision is now accepted and ready to land.Apr 14 2023, 5:47 AM

bartek added inline comments.Apr 14 2023, 9:39 AM

native/schema/CommUtilsModuleSchema.js
9	codegen doesn't like opaque type either :/

Rebase before landing

Harbormaster completed remote builds in B18598: Diff 25475.Apr 21 2023, 12:58 AM

Closed by commit rCOMMb96b35d54c19: [native] Add CommUtilsModule spec (authored by bartek). · Explain WhyApr 21 2023, 2:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb96b35d54c19: [native] Add CommUtilsModule spec.

Revision Contents
Changeset List

Path

Size

native/

schema/

CommUtilsModuleSchema.js

26 lines

Diff 25160

View Options

native/schema/CommUtilsModuleSchema.js

[native] Add CommUtilsModule specClosedPublicActions