Page MenuHomePhabricator
Differential D7480

[Tunnelbroker] Create session creation and key messages
ClosedPublic
Actions

Authored by • jon on Apr 17 2023, 6:35 PM.
Tags
None
Referenced Files
F3384471: D7480.diff
Thu, Nov 28, 9:07 PM
Unknown Object (File)
Mon, Nov 25, 9:34 AM
Unknown Object (File)
Mon, Nov 25, 9:27 AM
Unknown Object (File)
Mon, Nov 25, 8:52 AM
Unknown Object (File)
Mon, Nov 25, 8:37 AM
Unknown Object (File)
Fri, Nov 22, 8:11 AM
Unknown Object (File)
Thu, Nov 7, 4:38 AM
Unknown Object (File)
Thu, Nov 7, 4:38 AM
View All Files
Subscribers
atul
tomek

Details

Reviewers
varun
bartek
• max
ashoat
Commits
rCOMMbb6772194b9a: [Tunnelbroker] Create session creation and key messages
Summary

Remove "legacy" tunnelbroker api messages, and replace with
websocket messages.

Part of https://linear.app/comm/issue/ENG-3676

Depends on D7431

Test Plan

This is more intended to be a design diff. However, deserialization is tested

cd shared/tunnelbroker_messages
cargo test

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/identity-tunnelbroker (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Apr 17 2023, 6:35 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptApr 17 2023, 6:35 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 17 2023, 6:38 PM
Harbormaster failed remote builds in B18432: Diff 25247!
• jon updated this revision to Diff 25250.Apr 17 2023, 6:49 PM

Rebase on changes

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 17 2023, 6:54 PM
Harbormaster failed remote builds in B18435: Diff 25250!
• jon updated this revision to Diff 25266.Apr 18 2023, 7:59 AM

Rebase on fixes

Harbormaster completed remote builds in B18449: Diff 25266.Apr 18 2023, 8:16 AM
• jon requested review of this revision.Apr 18 2023, 8:16 AM
ashoat resigned from this revision.Apr 18 2023, 9:20 AM

New libraries look good!! Resigning so that somebody else on the team looks at the Rust code

bartek accepted this revision.Apr 18 2023, 11:46 AM

Rust looks good

This revision is now accepted and ready to land.Apr 18 2023, 11:46 AM
Closed by commit rCOMMbb6772194b9a: [Tunnelbroker] Create session creation and key messages (authored by • jon). · Explain WhyApr 19 2023, 10:25 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMbb6772194b9a: [Tunnelbroker] Create session creation and key messages.
kamil mentioned this in D8752: [Keyserver] Upload new onetime keys to identity service when requested.Sep 13 2023, 6:10 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
websockets/
2 lines
shared/
tunnelbroker_messages/
1 line
10 lines
src/
3 lines
messages/
28 lines
6 lines
68 lines

Diff 25266

View Options

services/tunnelbroker/src/websockets/messages.rs

Loading...
View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/.gitignore

Loading...
View Options

shared/tunnelbroker_messages/Cargo.lock

Loading...
View Options

shared/tunnelbroker_messages/Cargo.toml

Loading...
View Options

shared/tunnelbroker_messages/src/lib.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/keys.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/session.rs

Loading...