Paths

Table of Contentst

-
native/
-
avatars/
-
edit-user-avatar.react.js
-
profile/
-
profile-screen.react.js

[native] Move `UserAvatar` "inside" `EditUserAvatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 3:47 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM912799556ba0: [native] Move `UserAvatar` "inside" `EditUserAvatar`

Summary

Intead of passing in UserAvatar as React.Node as a prop to EditUserAvatar, we pass ?userID as a prop and render UserAvatar "inside" EditUserAvatar.

Depends on D7507

Test Plan

Things continue to look and work as expected:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 18 2023, 3:47 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 3:47 PM

atul added a child revision: D7509: [native] Move `ThreadAvatar` "inside" `EditThreadAvatar`.Apr 18 2023, 4:00 PM

atul edited the test plan for this revision. (Show Details)Apr 18 2023, 4:00 PM

Harbormaster completed remote builds in B18485: Diff 25316.Apr 18 2023, 4:04 PM

atul requested review of this revision.Apr 18 2023, 4:05 PM

ashoat accepted this revision.Apr 19 2023, 6:03 AM

This revision is now accepted and ready to land.Apr 19 2023, 6:03 AM

Closed by commit rCOMM912799556ba0: [native] Move `UserAvatar` "inside" `EditUserAvatar` (authored by atul). · Explain WhyApr 19 2023, 9:28 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM912799556ba0: [native] Move `UserAvatar` "inside" `EditUserAvatar`.

Revision Contents
Changeset List

Path

Size

native/

avatars/

edit-user-avatar.react.js

7 lines

profile/

profile-screen.react.js

9 lines

Diff 25316

View Options

native/avatars/edit-user-avatar.react.js