Page MenuHomePhabricator
Differential D7573

[native] convert useSelectFromGallery to selectFromGallery
ClosedPublic
Actions

Authored by ginsu on Apr 21 2023, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 1:03 AM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:25 PM
Unknown Object (File)
Dec 5 2024, 2:33 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMb6685a707cbb: [native] convert useSelectFromGallery to selectFromGallery
Summary

We don't need to use a hook for this function since we are not dealing with state or other react hooks

Test Plan

No flow errors, and I was still able to create a new avatar from a photo in my gallery

Diff Detail

Repository
rCOMM Comm
Branch
avatars-cleanup (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 21 2023, 12:28 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 21 2023, 12:28 PM
ginsu updated this revision to Diff 25562.Apr 21 2023, 12:31 PM

remove export for useUploadSelectedMedia

Harbormaster completed remote builds in B18662: Diff 25561.Apr 21 2023, 12:46 PM
Harbormaster completed remote builds in B18663: Diff 25562.Apr 21 2023, 12:48 PM
ginsu requested review of this revision.Apr 21 2023, 12:48 PM
ginsu added reviewers: ashoat, atul.Apr 25 2023, 12:59 PM
ginsu added a child revision: D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.
ashoat accepted this revision.Apr 25 2023, 1:02 PM
This revision is now accepted and ready to land.Apr 25 2023, 1:02 PM
ginsu added a child revision: D7626: [native] introduce edit user avatar provider scaffolding.Apr 25 2023, 1:58 PM
ginsu removed a child revision: D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.Apr 25 2023, 2:01 PM
ginsu updated this revision to Diff 25723.Apr 25 2023, 2:50 PM

rebase before landing

Harbormaster completed remote builds in B18776: Diff 25723.Apr 25 2023, 3:08 PM
Closed by commit rCOMMb6685a707cbb: [native] convert useSelectFromGallery to selectFromGallery (authored by ginsu). · Explain WhyApr 25 2023, 3:22 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb6685a707cbb: [native] convert useSelectFromGallery to selectFromGallery.

Revision Contents
Changeset List

PathSize
native/
avatars/
89 lines

Diff 25561

View Options

native/avatars/avatar-hooks.js

Loading...