Details

Reviewers

atul
ashoat

Commits

rCOMMa7a94f7b5f57: [native] move selecting from gallery logic from avatar hooks to edit user…

Summary

This diff moves the logic for setting an avatar using your photo gallery from avatar hooks to edit user avatar provider. This diff wraps up the introduction of introducing the edit user avatar provider

Depends on D7627

Test Plan

I tested all the avatar options we had (ENS, Emoji, and Photo gallery) and in all cases the behvaoir was to be expected with setting the avatar, loading while the avatar was saved

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 25 2023, 12:58 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 12:58 PM

ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 12:59 PM

ginsu added reviewers: atul, ashoat.

ginsu added a parent revision: D7573: [native] convert useSelectFromGallery to selectFromGallery.

ginsu added a child revision: D7622: [native] move navigate to emoji user avatar creation function to be within edit user avatar.Apr 25 2023, 1:12 PM

Harbormaster completed remote builds in B18762: Diff 25706.Apr 25 2023, 1:16 PM

ginsu requested review of this revision.Apr 25 2023, 1:16 PM

https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314

This revision now requires changes to proceed.Apr 25 2023, 1:25 PM

ginsu mentioned this in D7626: [native] introduce edit user avatar provider scaffolding.Apr 25 2023, 1:58 PM

ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 2:01 PM

ginsu removed a parent revision: D7573: [native] convert useSelectFromGallery to selectFromGallery.

break down diff

ginsu retitled this revision from [native] introduce edit user avatar provider to [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.Apr 25 2023, 2:41 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.

ginsu added inline comments.

native/avatars/edit-user-avatar-provider.react.js
82	Only change here is changing the name from `setProcessingOrUploadInProgress` to `setUserAvatarMediaUploadInProgress`

fix import order

native/avatars/edit-user-avatar-provider.react.js
82 ↗	(On Diff #25724)	Only change here is changing the name from `setProcessingOrUploadInProgress` to `setUserAvatarMediaUploadInProgress`

Harbormaster completed remote builds in B18774: Diff 25721.Apr 25 2023, 2:57 PM

Harbormaster completed remote builds in B18777: Diff 25724.Apr 25 2023, 3:12 PM

ashoat requested changes to this revision.Apr 25 2023, 6:04 PM

ashoat added inline comments.

native/avatars/edit-user-avatar-provider.react.js
56–61 ↗	(On Diff #25724)	We don't need this `useMemo`. Memoization is pretty much never worth doing when you're returning a primitive. The only reason would be for a really expensive calculation (rare)
86 ↗	(On Diff #25724)	Avoid implicit `return` undefined and throw here