Page MenuHomePhabricator

[native] Introduce designSystemColors to colors.js
ClosedPublic

Authored by ashoat on May 15 2023, 10:41 AM.
Tags
None
Referenced Files
F3388466: D7820.id26480.diff
Fri, Nov 29, 2:27 PM
Unknown Object (File)
Tue, Nov 26, 4:49 AM
Unknown Object (File)
Tue, Nov 26, 2:37 AM
Unknown Object (File)
Sun, Nov 17, 3:50 AM
Unknown Object (File)
Sun, Nov 17, 3:50 AM
Unknown Object (File)
Sun, Nov 17, 3:48 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Oct 17 2024, 12:33 AM
Subscribers

Details

Summary

Following discussion offline and in D7740, we want to make native/themes/colors.js look more like web/theme.css, where the design system colors are defined at the top of the page in their own struct, and the domain-specific usages all references the design system colors.

There are many cases of colors that are using in the mobile app that are NOT in the design system. We'll sync with @ted on this and come back to it later.

Test Plan

Flow, careful reading

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/colors
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Sweet, I think this will make colors.js much easier to work w/ in the future.

This revision is now accepted and ready to land.May 15 2023, 11:13 AM
This revision is now accepted and ready to land.May 15 2023, 11:14 AM