Paths

Table of Contentst

[native] Create expo-module for Thumbhash generation
ClosedPublic
Actions

Authored by bartek on May 10 2023, 3:59 AM.

Details

Reviewers

ashoat
atul
marcin

Commits

rCOMM23665e51b022: [native] Create expo-module for Thumbhash generation

Summary

Thumbhash generation requires raw pixel RGB data, which is not easily available from JS, but we can easily get it in native code. Created an expo module for that purpose.
Basically copy-pasted the aes-crypto module.

Test Plan

generateThumbHash("foo").then(console.log) prints "unimplemented" on iOS and Android

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 10 2023, 3:59 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMay 10 2023, 3:59 AM

Harbormaster completed remote builds in B19235: Diff 26335.May 10 2023, 4:22 AM

bartek published this revision for review.May 10 2023, 5:20 AM

bartek edited the summary of this revision. (Show Details)

bartek edited the test plan for this revision. (Show Details)

bartek added a child revision: D7779: [native] Implement thumbhash generation on iOS.May 10 2023, 6:04 AM

ashoat accepted this revision.May 11 2023, 8:30 AM

This revision is now accepted and ready to land.May 11 2023, 8:30 AM

Rebase

Harbormaster completed remote builds in B19433: Diff 26583.May 17 2023, 3:45 AM

Closed by commit rCOMM23665e51b022: [native] Create expo-module for Thumbhash generation (authored by bartek). · Explain WhyMay 17 2023, 4:39 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM23665e51b022: [native] Create expo-module for Thumbhash generation.

Revision Contents
Changeset List

Path

Size

.dockerignore

1 line

keyserver/

Dockerfile

2 lines

native/

expo-modules/

thumbhash/

android/

build.gradle

92 lines

src/

main/

AndroidManifest.xml

2 lines

java/

app/

comm/

android/

thumbhash/

ThumbhashModule.kt

14 lines

expo-module.config.json

9 lines

ios/

Thumbhash.podspec

27 lines

ThumbhashModule.swift

11 lines

package.json

17 lines

ios/

Podfile.lock

6 lines

package.json

1 line

utils/

thumbhash-module.js

18 lines

package.json

1 line

Diff 26597

View Options

.dockerignore

View Options

keyserver/Dockerfile

View Options

native/expo-modules/thumbhash/android/build.gradle

View Options

native/expo-modules/thumbhash/android/src/main/AndroidManifest.xml

View Options

native/expo-modules/thumbhash/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

View Options

native/expo-modules/thumbhash/expo-module.config.json

View Options

native/expo-modules/thumbhash/ios/Thumbhash.podspec

View Options

native/expo-modules/thumbhash/ios/ThumbhashModule.swift

View Options

native/expo-modules/thumbhash/package.json

View Options

native/ios/Podfile.lock

View Options

native/package.json

View Options

native/utils/thumbhash-module.js

View Options

[native] Create expo-module for Thumbhash generationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26597

.dockerignore

keyserver/Dockerfile

native/expo-modules/thumbhash/android/build.gradle

native/expo-modules/thumbhash/android/src/main/AndroidManifest.xml

native/expo-modules/thumbhash/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

native/expo-modules/thumbhash/expo-module.config.json

native/expo-modules/thumbhash/ios/Thumbhash.podspec

native/expo-modules/thumbhash/ios/ThumbhashModule.swift

native/expo-modules/thumbhash/package.json

native/ios/Podfile.lock

native/package.json

native/utils/thumbhash-module.js

package.json

[native] Create expo-module for Thumbhash generation
ClosedPublic
Actions

Revision Contents
Changeset List