Page MenuHomePhabricator
Differential D7959

[web] Open invite link modal when the link is clicked
ClosedPublic
Actions

Authored by tomek on May 24 2023, 9:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 10:58 PM
Unknown Object (File)
Sat, Mar 1, 10:40 PM
Unknown Object (File)
Wed, Feb 26, 5:30 PM
Unknown Object (File)
Wed, Feb 26, 7:56 AM
Unknown Object (File)
Tue, Feb 25, 2:46 PM
Unknown Object (File)
Sat, Feb 22, 5:18 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked
Summary

When a user isn't logged in, we show login panel. When a user logs in, we show a modal.

Depends on D7958

Test Plan

Open invite link as a logged-in user - a modal should appear.
Open the link as a logged-out user. A login form should appear. After successful login, the modal appears.

Diff Detail

Repository
rCOMM Comm
Branch
invite2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 24 2023, 9:38 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 24 2023, 9:38 AM
tomek added inline comments.May 24 2023, 9:39 AM
web/invite-links/invite-link-handler.react.js
33–36

We're making sure that one link click causes at most one modal open

Harbormaster completed remote builds in B19742: Diff 27001.May 24 2023, 9:57 AM
tomek requested review of this revision.May 24 2023, 9:57 AM
inka accepted this revision.May 25 2023, 12:52 AM
This revision is now accepted and ready to land.May 25 2023, 12:52 AM
Closed by commit rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked (authored by tomek). · Explain WhyMay 25 2023, 7:30 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked.

Revision Contents
Changeset List

PathSize
web/
2 lines
invite-links/
63 lines

Diff 27001

View Options

web/app.react.js

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines match message_to_tunnelbroker {
.db_client .db_client
.set_device_token( .set_device_token(
&self.device_info.device_id, &self.device_info.device_id,
&token.device_token, &token.device_token,
None, None,
) )
.await?; .await?;
} }
MessageToTunnelbroker::SetDeviceTokenWithPlatform(
token_with_platform,
) => {
self
.db_client
.set_device_token(
&self.device_info.device_id,
&token_with_platform.device_token,
Some(token_with_platform.platform.clone()),
)
.await?;
}
} }
Ok(()) Ok(())
} }
pub async fn handle_websocket_frame_from_device( pub async fn handle_websocket_frame_from_device(
&mut self, &mut self,
msg: String, msg: String,
▲ Show 20 Lines • Show All 331 Lines • Show Last 20 Lines
View Options

web/invite-links/invite-link-handler.react.js

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines match message_to_tunnelbroker {
.db_client .db_client
.set_device_token( .set_device_token(
&self.device_info.device_id, &self.device_info.device_id,
&token.device_token, &token.device_token,
None, None,
) )
.await?; .await?;
} }
MessageToTunnelbroker::SetDeviceTokenWithPlatform(
token_with_platform,
) => {
self
.db_client
.set_device_token(
&self.device_info.device_id,
&token_with_platform.device_token,
Some(token_with_platform.platform.clone()),
)
.await?;
}
} }
Ok(()) Ok(())
} }
pub async fn handle_websocket_frame_from_device( pub async fn handle_websocket_frame_from_device(
&mut self, &mut self,
msg: String, msg: String,
▲ Show 20 Lines • Show All 331 Lines • Show Last 20 Lines