Paths

Table of Contentst

-
web/
1
app.react.js
-
invite-links/
1
invite-link-handler.react.js

[web] Open invite link modal when the link is clicked
ClosedPublic
Actions

Authored by tomek on May 24 2023, 9:38 AM.

Details

Reviewers

bartek
kamil
inka

Commits

rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked

Summary

When a user isn't logged in, we show login panel. When a user logs in, we show a modal.

Depends on D7958

Test Plan

Open invite link as a logged-in user - a modal should appear.
Open the link as a logged-out user. A login form should appear. After successful login, the modal appears.

Diff Detail

Repository

rCOMM Comm

Branch

invite2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 24 2023, 9:38 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 24 2023, 9:38 AM

tomek added inline comments.May 24 2023, 9:39 AM

web/invite-links/invite-link-handler.react.js
33–36	We're making sure that one link click causes at most one modal open

Harbormaster completed remote builds in B19742: Diff 27001.May 24 2023, 9:57 AM

tomek requested review of this revision.May 24 2023, 9:57 AM

inka accepted this revision.May 25 2023, 12:52 AM

This revision is now accepted and ready to land.May 25 2023, 12:52 AM

Closed by commit rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked (authored by tomek). · Explain WhyMay 25 2023, 7:30 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM0fa8345729df: [web] Open invite link modal when the link is clicked.

Revision Contents
Changeset List

Path

Size

web/

app.react.js

2 lines

invite-links/

invite-link-handler.react.js

63 lines

Diff 27001

View Options

web/app.react.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines	) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2;		return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
}		}

function threadIsPending(threadID: ?string): boolean {		function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending');		return !!threadID?.startsWith('pending');
}		}

function threadIsPendingSidebar(threadID: ?string): boolean {		function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/');		return (
		!!threadID?.startsWith('pending/sidebar/') \|\|
		!!threadID?.startsWith('pending/dm_sidebar')
		tomekUnsubmitted Not Done Inline Actions Can we extract `sidebar` and `dm_sidebar` somewhere as constants? tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
		);
}		}

function getSingleOtherUser(		function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo \| RawThreadInfo \| ThreadInfo,		threadInfo: LegacyRawThreadInfo \| RawThreadInfo \| ThreadInfo,
viewerID: ?string,		viewerID: ?string,
): ?string {		): ?string {
if (!viewerID) {		if (!viewerID) {
return undefined;		return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines