Paths

Table of Contentst

[native] Move AndroidLifecycle to umbrella expo module
ClosedPublic
Actions

Authored by bartek on May 24 2023, 10:03 AM.

Details

Reviewers

ashoat
atul
marcin

Commits

rCOMM581a65e078ee: [native] Move AndroidLifecycle to umbrella expo module

Summary

Part of ENG-3871. This diff moves the AndroidLifecycle module to the umbrella expo module.

Basically only moved the files to another directory and updated expo-module.config.json. Also needed to add dependencies to build.gradle

Depends on D7961

Test Plan

Built Android, added console.log to event listener in lifecycle-module.js. Switched app foreground <-> background and ensured that the log is printed.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 24 2023, 10:03 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2023, 10:03 AM

bartek added a child revision: D7963: [native] Move Thumbhash to umbrella expo module.May 24 2023, 10:07 AM

Harbormaster completed remote builds in B19747: Diff 27006.May 24 2023, 10:21 AM

bartek published this revision for review.May 24 2023, 10:33 AM

ashoat accepted this revision.May 24 2023, 11:17 AM

This revision is now accepted and ready to land.May 24 2023, 11:17 AM

Closed by commit rCOMM581a65e078ee: [native] Move AndroidLifecycle to umbrella expo module (authored by bartek). · Explain WhyMay 24 2023, 11:24 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM581a65e078ee: [native] Move AndroidLifecycle to umbrella expo module.

Revision Contents
Changeset List

Path

Size

.dockerignore

1 line

keyserver/

Dockerfile

2 lines

native/

expo-modules/

android-lifecycle/

android/

build.gradle

src/

main/

AndroidManifest.xml

java/

app/

comm/

android/

lifecycle/

AndroidLifecycleModule.kt

expo-module.config.json

package.json

comm-expo-package/

android/

build.gradle

4 lines

expo-module.config.json

1 line

	comm-expo-package/	android/	src/	main/	java/	app/	comm/	android/	lifecycle/
	android-lifecycle/	android/	src/	main/	java/	app/	comm/	android/	lifecycle/

AndroidLifecycleModule.kt

74 lines

package.json

1 line

package.json

1 line

Diff 27006

View Options

.dockerignore

View Options

keyserver/Dockerfile

View Options

native/expo-modules/android-lifecycle/android/build.gradle

View Options

native/expo-modules/android-lifecycle/android/src/main/AndroidManifest.xml

View Options

native/expo-modules/android-lifecycle/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

View Options

native/expo-modules/android-lifecycle/expo-module.config.json

View Options

native/expo-modules/android-lifecycle/package.json

View Options

native/expo-modules/comm-expo-package/android/build.gradle

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

View Options

native/expo-modules/comm-expo-package/expo-module.config.json

View Options

native/package.json

View Options

[native] Move AndroidLifecycle to umbrella expo moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27006

.dockerignore

keyserver/Dockerfile

native/expo-modules/android-lifecycle/android/build.gradle

native/expo-modules/android-lifecycle/android/src/main/AndroidManifest.xml

native/expo-modules/android-lifecycle/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

native/expo-modules/android-lifecycle/expo-module.config.json

native/expo-modules/android-lifecycle/package.json

native/expo-modules/comm-expo-package/android/build.gradle

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

native/expo-modules/comm-expo-package/expo-module.config.json

native/package.json

package.json

[native] Move AndroidLifecycle to umbrella expo module
ClosedPublic
Actions

Revision Contents
Changeset List