Page MenuHomePhabricator
Differential D8022

[native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar
ClosedPublic
Actions

Authored by ashoat on May 29 2023, 5:41 PM.
Tags
None
Referenced Files
F3402265: D8022.diff
Mon, Dec 2, 3:38 PM
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Oct 28 2024, 1:03 AM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Unknown Object (File)
Oct 15 2024, 6:25 PM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
View All 82 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar
Summary

Same diff as D8019, just for thread avatars instead of user avatars.

In the last diff I removed useSaveThreadAvatar, but after comparing the Alert code I think the old code was better.

This diff migrates us to using that Alert code across all callsites.

Depends on D8021

Test Plan

Flow / careful reading, make sure app still runs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 29 2023, 5:41 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 29 2023, 5:41 PM
ashoat added a child revision: D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.May 29 2023, 5:45 PM
ashoat mentioned this in D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.May 29 2023, 5:47 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 29 2023, 5:56 PM
Harbormaster failed remote builds in B19882: Diff 27238!
ashoat updated this revision to Diff 27242.May 29 2023, 6:01 PM

Rebase to fix ESLint error

Harbormaster completed remote builds in B19886: Diff 27242.May 29 2023, 6:19 PM
ashoat requested review of this revision.May 29 2023, 6:19 PM
atul accepted this revision.May 30 2023, 9:34 AM
This revision is now accepted and ready to land.May 30 2023, 9:34 AM
ashoat updated this revision to Diff 27279.May 30 2023, 12:06 PM

displayFailureAlert

This revision was landed with ongoing or failed builds.May 30 2023, 12:09 PM
Closed by commit rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
Harbormaster completed remote builds in B19917: Diff 27279.May 30 2023, 12:24 PM

Revision Contents
Changeset List

PathSize
native/
avatars/
12 lines

Diff 27242

View Options

native/avatars/edit-thread-avatar-provider.react.js

Loading...