Page MenuHomePhabricator

[native] Unify alert behavior when changing selected edited message
ClosedPublic

Authored by kuba on May 31 2023, 2:31 AM.
Tags
None
Referenced Files
F1813915: D8036.id27713.diff
Tue, May 21, 3:16 PM
F1804940: D8036.id27293.diff
Mon, May 20, 10:29 PM
Unknown Object (File)
Fri, May 17, 9:29 AM
Unknown Object (File)
Sat, May 4, 8:47 AM
Unknown Object (File)
Tue, Apr 30, 7:33 AM
Unknown Object (File)
Mar 31 2024, 5:58 PM
Unknown Object (File)
Mar 31 2024, 5:58 PM
Unknown Object (File)
Mar 31 2024, 5:56 PM
Subscribers

Details

Summary
  • removed confirmation alert, when changing edited message and didn't make changes to the previous message,
  • removed the Edit button for the currently edited message.
Test Plan

Tested on iOS:

  • entered edit mode,
  • tried to edit the same message, checked if the edit button doesn't appear,
  • made some changes in the edited message,
  • tried to edit another message, checked if the confirmation alert is displayed,
  • entered edit mode, didn't make changes, checked if can select another message to edit without confirmation alert,

Diff Detail

Repository
rCOMM Comm
Branch
kuba/check-enter-edit
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/chat/chat-input-bar.react.js
847–848

I had to add newText, to always have the latest version of the draft. It is used when we want to both set a new text state and check if the message has any changes (line 737).

This revision is now accepted and ready to land.Jun 5 2023, 3:12 AM