Page MenuHomePhabricator

[native] Unify alert behavior when changing selected edited message
ClosedPublic

Authored by kuba on May 31 2023, 2:31 AM.
Tags
None
Referenced Files
F1682937: D8036.diff
Tue, Apr 30, 7:33 AM
Unknown Object (File)
Sun, Mar 31, 5:58 PM
Unknown Object (File)
Sun, Mar 31, 5:58 PM
Unknown Object (File)
Sun, Mar 31, 5:56 PM
Unknown Object (File)
Sun, Mar 31, 5:41 PM
Unknown Object (File)
Feb 26 2024, 9:55 PM
Unknown Object (File)
Feb 26 2024, 9:55 PM
Unknown Object (File)
Feb 26 2024, 9:55 PM
Subscribers

Details

Summary
  • removed confirmation alert, when changing edited message and didn't make changes to the previous message,
  • removed the Edit button for the currently edited message.
Test Plan

Tested on iOS:

  • entered edit mode,
  • tried to edit the same message, checked if the edit button doesn't appear,
  • made some changes in the edited message,
  • tried to edit another message, checked if the confirmation alert is displayed,
  • entered edit mode, didn't make changes, checked if can select another message to edit without confirmation alert,

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/chat/chat-input-bar.react.js
847–848 ↗(On Diff #27293)

I had to add newText, to always have the latest version of the draft. It is used when we want to both set a new text state and check if the message has any changes (line 737).

This revision is now accepted and ready to land.Jun 5 2023, 3:12 AM