Page MenuHomePhabricator

[native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc
ClosedPublic

Authored by ashoat on May 31 2023, 1:09 PM.
Tags
None
Referenced Files
F3409899: D8042.id27320.diff
Wed, Dec 4, 7:06 PM
F3409857: D8042.id27361.diff
Wed, Dec 4, 6:57 PM
F3408643: D8042.diff
Wed, Dec 4, 12:12 PM
Unknown Object (File)
Wed, Nov 13, 8:11 AM
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Fri, Nov 8, 6:24 AM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Subscribers

Details

Summary

This simple refactor diff moves the useSelector to the parent component, allowing the child component to take any generic function.

This slightly improves performance in the case where selection from Redux state is not needed, which is the case in the new registration flow.

Depends on D8041

Test Plan

Flow, along with the testing I did for the whole stack:

  1. ENS flow, both when user has an ENS avatar and when they don't
  2. Setting an emoji avatar
  3. Setting an image avatar via camera
  4. Setting an image avatar via media library
  5. Tested avatar update flow after being logged in to make sure I didn't regress anything

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable