[lib] Introduce new GenericUserInfoWithAvatar type
ClosedPublic
Actions

Authored by ashoat on May 31 2023, 1:15 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM33be0a69d6ae: [lib] Introduce new GenericUserInfoWithAvatar type

Summary

I'll reuse this in later diffs, so factoring it out here.

Depends on D8044

Test Plan

Flow, along with the testing I did for the whole stack:

ENS flow, both when user has an ENS avatar and when they don't
Setting an emoji avatar
Setting an image avatar via camera
Setting an image avatar via media library
Tested avatar update flow after being logged in to make sure I didn't regress anything

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 31 2023, 1:15 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 31 2023, 1:15 PM

ashoat added a child revision: D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.May 31 2023, 1:16 PM

Harbormaster completed remote builds in B19936: Diff 27323.May 31 2023, 1:35 PM

ashoat requested review of this revision.May 31 2023, 1:35 PM

atul accepted this revision.Jun 1 2023, 11:21 AM

This revision is now accepted and ready to land.Jun 1 2023, 11:21 AM

Closed by commit rCOMM33be0a69d6ae: [lib] Introduce new GenericUserInfoWithAvatar type (authored by ashoat). · Explain WhyJun 1 2023, 11:52 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM33be0a69d6ae: [lib] Introduce new GenericUserInfoWithAvatar type.

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

9 lines

types/

avatar-types.js

6 lines

Diff 27364

View Options

lib/shared/avatar-utils.js