Page MenuHomePhabricator

[native] Construct synthetic UserInfo to pass to EditUserAvatar
ClosedPublic

Authored by ashoat on May 31 2023, 1:16 PM.
Tags
None
Referenced Files
F3409828: D8046.id27324.diff
Wed, Dec 4, 6:46 PM
F3408672: D8046.diff
Wed, Dec 4, 12:24 PM
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Aug 31 2024, 7:05 PM
Subscribers

Details

Summary

EditUserAvatar renders an avatar via UserAvatar, which currently only works when the data (UserInfo or CurrentUserInfo) is in Redux.

For the registration flow, we want to render a "pending" avatar that hasn't been saved into Redux yet. To that end, this diff introduces a way to pass UserInfo to UserAvatar and EditUserAvatar.

Depends on D8045

Test Plan

This was tested in combination with the rest of the stack. I tested:

  1. ENS flow, both when user has an ENS avatar and when they don't
  2. Setting an emoji avatar
  3. Setting an image avatar via camera
  4. Setting an image avatar via media library
  5. Tested avatar update flow after being logged in to make sure I didn't regress anything

To see the UI in action, check out the video in D8049!

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable