[web-db] avoid database init on app start on Safari
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 5:20 PM.

Details

Reviewers

michal
tomek

Commits

rCOMM85723467d32c: [web-db] avoid database init on app start on Safari

Summary

In general, we establish database connection immediately after app start, on Safari we need to wait for encryption key generated from main thread.
(context)

Depends on D8123

Test Plan

Database should be inited from sqlite-data-handler.js

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 6 2023, 5:20 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 5:20 PM

kamil added a child revision: D8125: [web-db] restore database Safari support.Jun 6 2023, 5:21 PM

Harbormaster completed remote builds in B20061: Diff 27491.Jun 6 2023, 5:39 PM

kamil published this revision for review.Jun 7 2023, 8:52 AM

kamil added inline comments.

web/database/database-module-provider.js
38	Naming might be confusing, but at this point database is not supported (we don't have a key to it), it will be supported after main thread will provide encryption key

tomek accepted this revision.Jun 13 2023, 11:31 AM

tomek added inline comments.

web/database/database-module-provider.js
37	Can we have a const instead of a function that tells if it is Safari? We can avoid having to detect the browser multiple times, as this fact doesn't change through the lifetime of the app.

This revision is now accepted and ready to land.Jun 13 2023, 11:31 AM

tomek added inline comments.Jun 13 2023, 11:32 AM