Paths

Table of Contentst

[lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 12:08 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMafc1464ca5ed: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`

Summary

In previous two diffs (D8213, D8215), we made EditUserAvatarProvider "platform-agnostic" so it could be used across web and native.

This diff is just a move + fix imports diff.

Depends on D8215

Test Plan

Can still select media/upload media to set image user avatar as before.
Also killed keyserver and made sure Alert still appeared as expected on native when upload fails.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 14 2023, 12:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 12:08 PM

atul published this revision for review.Jun 14 2023, 12:11 PM

ginsu accepted this revision.Jun 14 2023, 12:21 PM

This revision is now accepted and ready to land.Jun 14 2023, 12:21 PM

Harbormaster completed remote builds in B20271: Diff 27786.Jun 14 2023, 12:28 PM

atul added a child revision: D8217: [native] Introduce `NativeEditUserAvatarProvider`.Jun 14 2023, 12:29 PM

Closed by commit rCOMMafc1464ca5ed: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib` (authored by atul). · Explain WhyJun 14 2023, 2:22 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMafc1464ca5ed: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`.

Revision Contents
Changeset List

Path

Size

	lib/	components/
	native/	avatars/

edit-user-avatar-provider.react.js

15 lines

native/

account/

registration/

avatar-selection.react.js

9 lines

emoji-avatar-selection.react.js

2 lines

registration-server-call.js

2 lines

avatars/

edit-user-avatar-provider.react.js

edit-user-avatar.react.js

2 lines

media/

registration-user-avatar-camera-modal.react.js

3 lines

user-avatar-camera-modal.react.js

3 lines

profile/

emoji-user-avatar-creation.react.js

2 lines

root.react.js

2 lines

Diff 27786

View Options

lib/components/edit-user-avatar-provider.react.js

View Options

native/account/registration/avatar-selection.react.js

View Options

native/account/registration/emoji-avatar-selection.react.js

View Options

native/account/registration/registration-server-call.js

View Options

native/avatars/edit-user-avatar-provider.react.js

View Options

native/avatars/edit-user-avatar.react.js

View Options

native/media/registration-user-avatar-camera-modal.react.js

View Options

native/media/user-avatar-camera-modal.react.js

View Options

native/profile/emoji-user-avatar-creation.react.js

View Options

[lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27786

lib/components/edit-user-avatar-provider.react.js

native/account/registration/avatar-selection.react.js

native/account/registration/emoji-avatar-selection.react.js

native/account/registration/registration-server-call.js

native/avatars/edit-user-avatar-provider.react.js

native/avatars/edit-user-avatar.react.js

native/media/registration-user-avatar-camera-modal.react.js

native/media/user-avatar-camera-modal.react.js

native/profile/emoji-user-avatar-creation.react.js

native/root.react.js

[lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`
ClosedPublic
Actions

Revision Contents
Changeset List