[native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 1:05 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM0318bb6e09fe: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from…

Summary

As part of making EditThreadAvatarProvider "platform-agnostic" so it can be used across web and native, we're pulling out selectFromGallery and useUploadSelectedMedia out of EditThreadAvatarProvider.

This is the thread avatar version of D8215

Depends on D8218

Test Plan

Made sure I could still successfully select/upload image thread avatar from native.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 14 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 1:05 PM

atul published this revision for review.Jun 14 2023, 1:10 PM

Harbormaster completed remote builds in B20275: Diff 27792.Jun 14 2023, 1:24 PM

atul added a child revision: D8220: [native] Introduce `NativeEditThreadAvatarProvider`.Jun 14 2023, 1:43 PM

ashoat accepted this revision.Jun 15 2023, 7:26 AM

This revision is now accepted and ready to land.Jun 15 2023, 7:26 AM

atul closed this revision.Jun 16 2023, 11:33 AM

atul added a commit: rCOMM0318bb6e09fe: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from….Jun 16 2023, 11:41 AM

Revision Contents
Changeset List

Path

Size

native/

avatars/

edit-thread-avatar-provider.react.js

19 lines

root.react.js

6 lines

Diff 27792

View Options

native/avatars/edit-thread-avatar-provider.react.js