Page MenuHomePhabricator
Differential D8298

[identity] fix format of ed25519 public key and signature
ClosedPublic
Actions

Authored by varun on Jun 22 2023, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 7:16 AM
Unknown Object (File)
Thu, Mar 27, 9:22 PM
Unknown Object (File)
Sun, Mar 23, 11:00 AM
Unknown Object (File)
Thu, Mar 20, 10:38 PM
Unknown Object (File)
Mar 7 2025, 4:48 PM
Unknown Object (File)
Feb 25 2025, 12:50 PM
Unknown Object (File)
Feb 11 2025, 1:57 PM
Unknown Object (File)
Feb 11 2025, 1:57 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMb97e7a853b67: [identity] fix format of ed25519 public key and signature
Summary

the public key and signature should be decoded to byte slices.

Test Plan

tested two diffs later in stack when we verify signatures with the public key

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 22 2023, 11:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 11:43 PM
varun added a child revision: D8299: [keyserver] improve error messages in rust-node-addon.Jun 22 2023, 11:45 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 12:08 AM
Harbormaster failed remote builds in B20444: Diff 28026!
varun requested review of this revision.Jun 23 2023, 1:23 PM
• jon added a comment.Jun 26 2023, 5:55 AM

LGTM, would like for bartek to take a look.

bartek accepted this revision.Jun 26 2023, 3:21 PM
This revision is now accepted and ready to land.Jun 26 2023, 3:21 PM
This revision was landed with ongoing or failed builds.Jun 26 2023, 6:54 PM
Closed by commit rCOMMb97e7a853b67: [identity] fix format of ed25519 public key and signature (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMb97e7a853b67: [identity] fix format of ed25519 public key and signature.

Revision Contents
Changeset List

PathSize
services/
identity/
1 line
src/
19 lines

Diff 28026

View Options

services/identity/Cargo.lock

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

services/identity/Cargo.toml

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

services/identity/src/reserved_users.rs

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };