Page MenuHomePhabricator

[keyserver] Get rid of code for updating client ThreadStore when upgrade to codeVersion 70 occurs
ClosedPublic

Authored by ashoat on Jul 15 2023, 8:03 PM.
Tags
None
Referenced Files
F3553754: D8504.id28739.diff
Thu, Dec 26, 9:11 PM
F3541917: D8504.diff
Thu, Dec 26, 7:28 AM
Unknown Object (File)
Mon, Dec 16, 12:22 AM
Unknown Object (File)
Mon, Dec 16, 12:22 AM
Unknown Object (File)
Mon, Dec 16, 12:21 AM
Unknown Object (File)
Mon, Dec 16, 12:12 AM
Unknown Object (File)
Nov 7 2024, 9:45 PM
Unknown Object (File)
Oct 28 2024, 9:49 PM
Subscribers

Details

Summary

See the first diff in the stack. We're no longer expecting to see such an old codeVersion, so I'm going to delete this code.

This is admittedly slightly more risky than some of the other diffs in the stack, because this doesn't just break the USE of such an old codeVersion, but rather breaks the upgrade FROM such an old codeVersion.

However, I think it's safe because we don't currently have any logged-in sessions with such an old codeVersion, and we prevent log in / registration with such an old codeVersion in the parent diff. So we don't expect such an upgrade to occur.

Depends on D8503

Test Plan

I tested this whole stack together by playing around with the web app and making sure thread mutation endpoints seemed to work correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage