Page MenuHomePhabricator
Differential D8501

[identity] log out user RPC
ClosedPublic
Actions

Authored by varun on Jul 14 2023, 1:01 PM.
Tags
None
Referenced Files
F3367504: D8501.diff
Mon, Nov 25, 2:57 PM
Unknown Object (File)
Sun, Nov 24, 9:21 PM
Unknown Object (File)
Sat, Nov 23, 6:56 AM
Unknown Object (File)
Fri, Nov 22, 10:07 PM
Unknown Object (File)
Fri, Nov 22, 6:31 PM
Unknown Object (File)
Wed, Nov 13, 4:39 AM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM10f3533bf22d: [identity] log out user RPC
Summary

calling this RPC will clear a device's access token and keys from DDB

Depends on D8500

Test Plan

called the RPC from kreya and verified that my device's keys and token were removed from DDB

Diff Detail

Repository
rCOMM Comm
Branch
logout (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jul 14 2023, 1:01 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 14 2023, 1:01 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2023, 1:06 PM
Harbormaster failed remote builds in B20936: Diff 28690!
varun updated this revision to Diff 28840.Jul 19 2023, 7:26 AM

trigger CI

Harbormaster completed remote builds in B21044: Diff 28840.Jul 19 2023, 8:40 AM
varun requested review of this revision.Jul 19 2023, 8:40 AM
• jon requested changes to this revision.Jul 19 2023, 12:19 PM

Eventually, we should move this to the authenticated service

services/identity/src/client_service.rs
689–706

feel like this should just be a call to verify_access_token

This revision now requires changes to proceed.Jul 19 2023, 12:19 PM
varun updated this revision to Diff 29873.Aug 14 2023, 11:59 AM

addressed feedback. found a few other instances where we could simplify logic by calling verify_access_token

Harbormaster completed remote builds in B21738: Diff 29873.Aug 14 2023, 12:18 PM
• jon accepted this revision.Aug 15 2023, 9:42 AM

Accepting to not block progress.

Eventually this should be moved to the authenticated proto, however, that can wait until after https://phab.comm.dev/D8804 lands.

This revision is now accepted and ready to land.Aug 15 2023, 9:42 AM
Closed by commit rCOMM10f3533bf22d: [identity] log out user RPC (authored by varun). · Explain WhyAug 15 2023, 9:50 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM10f3533bf22d: [identity] log out user RPC.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
50 lines
shared/
protos/
12 lines

Diff 28840

View Options

services/identity/src/client_service.rs

Loading...
View Options

shared/protos/identity_client.proto

Loading...